pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove LRU cache

Browse Source
This commit is contained in:
George Drummond 2019-01-02 11:39:08 -05:00
parent aee61e856d
commit c274ad6d54
No known key found for this signature in database
GPG Key ID: 296DD6077123BF17
2 changed files with 4 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
atst/utils/localization.py
View File

@ -1,11 +1,8 @@
import yaml import yaml
import os import os
from flask import current_app as app from flask import current_app as app
from functools import lru_cache
from atst.utils import getattr_path from atst.utils import getattr_path
ENV = os.getenv("FLASK_ENV", "dev")
class LocalizationInvalidKeyError(Exception): class LocalizationInvalidKeyError(Exception):
def __init__(self, key, variables): def __init__(self, key, variables):
@ -18,26 +15,18 @@ class LocalizationInvalidKeyError(Exception):
) )
localizations_cache_size = 1 if ENV == "dev" else None
@lru_cache(maxsize=localizations_cache_size)
def load_cached_translations_file(file_name):
return open(file_name).read()
def _translations_file(): def _translations_file():
file_name = "translations.yaml" file_name = "translations.yaml"
if app: if app:
file_name = app.config.get("TRANSLATIONS_FILE") or file_name file_name = app.config.get("DEFAULT_TRANSLATIONS_FILE", file_name)
return file_name return open(file_name)
def translate(key, variables=None): def translate(key, variables=None):
translations_file = _translations_file() translations_file = _translations_file()
translations = yaml.safe_load(load_cached_translations_file(translations_file)) translations = yaml.safe_load(translations_file)
value = getattr_path(translations, key) value = getattr_path(translations, key)
if variables is None: if variables is None:

11
tests/utils/test_localization.py
View File

@ -1,14 +1,5 @@
import pytest import pytest
from atst.utils.localization import ( from atst.utils.localization import translate, LocalizationInvalidKeyError
translate,
load_cached_translations_file,
LocalizationInvalidKeyError,
)
def test_loading_cached_translations_file_returns_the_file_contents():
file_name = "translations.yaml"
assert load_cached_translations_file(file_name) == open(file_name).read()
def test_looking_up_existing_key(): def test_looking_up_existing_key():