pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Spelling error and better name use

Browse Source
This commit is contained in:
Montana 2018-11-15 10:30:21 -05:00
parent 49ed02ad04
commit c071945b3b
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
atst/models/workspace_role.py
View File

@ -49,8 +49,8 @@ class WorkspaceRole(Base, mixins.TimestampsMixin, mixins.AuditableMixin):
if "role_id" in previous_state: if "role_id" in previous_state:
from_role_id = previous_state["role_id"] from_role_id = previous_state["role_id"]
from_role = db.session.query(Role).filter(Role.id == from_role_id).one() from_role = db.session.query(Role).filter(Role.id == from_role_id).one()
to_role = self.role_displayname to_role = self.role_name
change_set["role"] = [from_role.display_name, to_role] change_set["role"] = [from_role.name, to_role]
if "status" in previous_state: if "status" in previous_state:
from_status = previous_state["status"].value from_status = previous_state["status"].value
to_status = self.status.value to_status = self.status.value

2
tests/domain/test_audit_log.py
View File

@ -20,7 +20,7 @@ def test_non_admin_cannot_view_audit_log(developer):
AuditLog.get_all_events(developer) AuditLog.get_all_events(developer)
def test_ccpo_can_iview_audit_log(ccpo): def test_ccpo_can_view_audit_log(ccpo):
AuditLog.get_all_events(ccpo) AuditLog.get_all_events(ccpo)

5
tests/models/test_workspace_role.py
View File

@ -44,8 +44,9 @@ def test_has_role_history(session):
.all() .all()
) )
assert changed_events[0].changed_state["role"][0] # changed_state["role"] returns a list [previous role, current role]
assert changed_events[0].changed_state["role"][1] assert changed_events[0].changed_state["role"][0] == 'developer'
assert changed_events[0].changed_state["role"][1] == 'admin'
def test_has_status_history(session): def test_has_status_history(session):