Merge pull request #503 from dod-ccpo/spike-new-workflow

Task Order Form

tests/domain/test_legacy_task_orders.py

@@ -0,0 +1,28 @@
+import pytest
+
+from atst.domain.exceptions import NotFoundError
+from atst.domain.legacy_task_orders import LegacyTaskOrders
+from atst.eda_client import MockEDAClient
+
+from tests.factories import LegacyTaskOrderFactory
+
+
+def test_can_get_task_order():
+    new_to = LegacyTaskOrderFactory.create(number="0101969F")
+    to = LegacyTaskOrders.get(new_to.number)
+
+    assert to.id == to.id
+
+
+def test_nonexistent_task_order_raises_without_client():
+    with pytest.raises(NotFoundError):
+        LegacyTaskOrders.get("some fake number")
+
+
+def test_nonexistent_task_order_raises_with_client(monkeypatch):
+    monkeypatch.setattr(
+        "atst.domain.legacy_task_orders.LegacyTaskOrders._client",
+        lambda: MockEDAClient(),
+    )
+    with pytest.raises(NotFoundError):
+        LegacyTaskOrders.get("some other fake numer")

tests/domain/test_projects.py

@@ -5,7 +5,7 @@ from atst.domain.workspaces import Workspaces
 
 def test_create_project_with_multiple_environments():
     request = RequestFactory.create()
-    workspace = Workspaces.create(request)
+    workspace = Workspaces.create_from_request(request)
     project = Projects.create(
         workspace.owner, workspace, "My Test Project", "Test", ["dev", "prod"]
     )

tests/domain/test_task_orders.py

@@ -1,28 +1,31 @@
 import pytest
 
-from atst.domain.exceptions import NotFoundError
-from atst.domain.legacy_task_orders import LegacyTaskOrders
-from atst.eda_client import MockEDAClient
+from atst.domain.task_orders import TaskOrders
 
-from tests.factories import LegacyTaskOrderFactory
+from tests.factories import TaskOrderFactory
 
 
-def test_can_get_task_order():
-    new_to = LegacyTaskOrderFactory.create(number="0101969F")
-    to = LegacyTaskOrders.get(new_to.number)
-
-    assert to.id == to.id
+def test_is_section_complete():
+    dict_keys = [k for k in TaskOrders.SECTIONS.keys()]
+    section = dict_keys[0]
+    attrs = TaskOrders.SECTIONS[section].copy()
+    task_order = TaskOrderFactory.create(**{k: None for k in attrs})
+    leftover = attrs.pop()
+    for attr in attrs:
+        setattr(task_order, attr, "str12345")
+    assert not TaskOrders.is_section_complete(task_order, section)
+    setattr(task_order, leftover, "str12345")
+    assert TaskOrders.is_section_complete(task_order, section)
 
 
-def test_nonexistent_task_order_raises_without_client():
-    with pytest.raises(NotFoundError):
-        LegacyTaskOrders.get("some fake number")
+def test_all_sections_complete():
+    task_order = TaskOrderFactory.create()
+    for attr_list in TaskOrders.SECTIONS.values():
+        for attr in attr_list:
+            if not getattr(task_order, attr):
+                setattr(task_order, attr, "str12345")
 
-
-def test_nonexistent_task_order_raises_with_client(monkeypatch):
-    monkeypatch.setattr(
-        "atst.domain.legacy_task_orders.LegacyTaskOrders._client",
-        lambda: MockEDAClient(),
-    )
-    with pytest.raises(NotFoundError):
-        LegacyTaskOrders.get("some other fake numer")
+    task_order.scope = None
+    assert not TaskOrders.all_sections_complete(task_order)
+    task_order.scope = "str12345"
+    assert TaskOrders.all_sections_complete(task_order)

tests/domain/test_workspaces.py

@@ -28,12 +28,12 @@ def request_(workspace_owner):
 
 @pytest.fixture(scope="function")
 def workspace(request_):
-    workspace = Workspaces.create(request_)
+    workspace = Workspaces.create_from_request(request_)
     return workspace
 
 
 def test_can_create_workspace(request_):
-    workspace = Workspaces.create(request_, name="frugal-whale")
+    workspace = Workspaces.create_from_request(request_, name="frugal-whale")
     assert workspace.name == "frugal-whale"
 
 
@@ -163,7 +163,9 @@ def test_need_permission_to_update_workspace_role_role(workspace, workspace_owne
 
 def test_owner_can_view_workspace_members(workspace, workspace_owner):
     workspace_owner = UserFactory.create()
-    workspace = Workspaces.create(RequestFactory.create(creator=workspace_owner))
+    workspace = Workspaces.create_from_request(
+        RequestFactory.create(creator=workspace_owner)
+    )
     workspace = Workspaces.get_with_members(workspace_owner, workspace.id)
 
     assert workspace
@@ -256,7 +258,7 @@ def test_for_user_returns_active_workspaces_for_user(workspace, workspace_owner)
     WorkspaceRoleFactory.create(
         user=bob, workspace=workspace, status=WorkspaceRoleStatus.ACTIVE
     )
-    Workspaces.create(RequestFactory.create())
+    Workspaces.create_from_request(RequestFactory.create())
 
     bobs_workspaces = Workspaces.for_user(bob)
 
@@ -266,7 +268,7 @@ def test_for_user_returns_active_workspaces_for_user(workspace, workspace_owner)
 def test_for_user_does_not_return_inactive_workspaces(workspace, workspace_owner):
     bob = UserFactory.from_atat_role("default")
     Workspaces.add_member(workspace, bob, "developer")
-    Workspaces.create(RequestFactory.create())
+    Workspaces.create_from_request(RequestFactory.create())
     bobs_workspaces = Workspaces.for_user(bob)
 
     assert len(bobs_workspaces) == 0
@@ -274,7 +276,7 @@ def test_for_user_does_not_return_inactive_workspaces(workspace, workspace_owner
 
 def test_for_user_returns_all_workspaces_for_ccpo(workspace, workspace_owner):
     sam = UserFactory.from_atat_role("ccpo")
-    Workspaces.create(RequestFactory.create())
+    Workspaces.create_from_request(RequestFactory.create())
 
     sams_workspaces = Workspaces.for_user(sam)
     assert len(sams_workspaces) == 2
@@ -282,7 +284,9 @@ def test_for_user_returns_all_workspaces_for_ccpo(workspace, workspace_owner):
 
 def test_get_for_update_information():
     workspace_owner = UserFactory.create()
-    workspace = Workspaces.create(RequestFactory.create(creator=workspace_owner))
+    workspace = Workspaces.create_from_request(
+        RequestFactory.create(creator=workspace_owner)
+    )
     owner_ws = Workspaces.get_for_update_information(workspace_owner, workspace.id)
     assert workspace == owner_ws
 
@@ -300,8 +304,8 @@ def test_get_for_update_information():
 
 def test_can_create_workspaces_with_matching_names():
     workspace_name = "Great Workspace"
-    Workspaces.create(RequestFactory.create(), name=workspace_name)
-    Workspaces.create(RequestFactory.create(), name=workspace_name)
+    Workspaces.create_from_request(RequestFactory.create(), name=workspace_name)
+    Workspaces.create_from_request(RequestFactory.create(), name=workspace_name)
 
 
 def test_able_to_revoke_workspace_access_for_active_member():