pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move dispatch_send_task_order_files tests into a test class

Browse Source
This commit is contained in:
leigh-mil 2020-02-18 10:56:35 -05:00
parent 411f0477e9
commit b8bf106a96
1 changed files with 61 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

127
tests/test_jobs.py
View File

@ -415,82 +415,77 @@ def test_create_environment_role():
assert env_role.cloud_id == "a-cloud-id" assert env_role.cloud_id == "a-cloud-id"
# TODO: Refactor the tests related to dispatch_send_task_order_files() into a class class TestDispatchSendTaskOrderFiles:
# and separate the success test into two tests @pytest.fixture(scope="function")
def test_dispatch_send_task_order_files(monkeypatch, app): def send_mail(self, monkeypatch):
mock = Mock() mock = Mock()
monkeypatch.setattr("atst.jobs.send_mail", mock) monkeypatch.setattr("atst.jobs.send_mail", mock)
return mock
def _download_task_order(MockFileService, object_name): @pytest.fixture(scope="function")
return {"name": object_name} def download_task_order(self, monkeypatch):
def _download_task_order(MockFileService, object_name):
return {"name": object_name}
monkeypatch.setattr( monkeypatch.setattr(
"atst.domain.csp.files.MockFileService.download_task_order", "atst.domain.csp.files.MockFileService.download_task_order",
_download_task_order, _download_task_order,
) )
# Create 3 new Task Orders def test_sends_multiple_emails(self, send_mail, download_task_order):
for i in range(3): # Create 3 Task Orders
TaskOrderFactory.create(create_clins=[{"number": "0001"}]) for i in range(3):
TaskOrderFactory.create(create_clins=[{"number": "0001"}])
dispatch_send_task_order_files.run() dispatch_send_task_order_files.run()
# Check that send_with_attachment was called once for each task order # Check that send_with_attachment was called once for each task order
assert mock.call_count == 3 assert send_mail.call_count == 3
mock.reset_mock()
# Create new TO def test_kwargs(self, send_mail, download_task_order, app):
task_order = TaskOrderFactory.create(create_clins=[{"number": "0001"}]) task_order = TaskOrderFactory.create(create_clins=[{"number": "0001"}])
assert not task_order.pdf_last_sent_at dispatch_send_task_order_files.run()
dispatch_send_task_order_files.run() # Check that send_with_attachment was called with correct kwargs
send_mail.assert_called_once_with(
recipients=[app.config.get("MICROSOFT_TASK_ORDER_EMAIL_ADDRESS")],
subject=translate(
"email.task_order_sent.subject", {"to_number": task_order.number}
),
body=translate(
"email.task_order_sent.body", {"to_number": task_order.number}
),
attachments=[
{
"name": task_order.pdf.object_name,
"maintype": "application",
"subtype": "pdf",
}
],
)
assert task_order.pdf_last_sent_at
# Check that send_with_attachment was called with correct kwargs def test_send_failure(self, monkeypatch):
mock.assert_called_once_with( def _raise_smtp_exception(**kwargs):
recipients=[app.config.get("MICROSOFT_TASK_ORDER_EMAIL_ADDRESS")], raise SMTPException
subject=translate(
"email.task_order_sent.subject", {"to_number": task_order.number}
),
body=translate("email.task_order_sent.body", {"to_number": task_order.number}),
attachments=[
{
"name": task_order.pdf.object_name,
"maintype": "application",
"subtype": "pdf",
}
],
)
assert task_order.pdf_last_sent_at monkeypatch.setattr("atst.jobs.send_mail", _raise_smtp_exception)
task_order = TaskOrderFactory.create(create_clins=[{"number": "0001"}])
dispatch_send_task_order_files.run()
# Check that pdf_last_sent_at has not been updated
assert not task_order.pdf_last_sent_at
def test_dispatch_send_task_order_files_send_failure(monkeypatch): def test_download_failure(self, send_mail, monkeypatch):
def _raise_smtp_exception(**kwargs): def _download_task_order(MockFileService, object_name):
raise SMTPException raise AzureError("something went wrong")
monkeypatch.setattr("atst.jobs.send_mail", _raise_smtp_exception) monkeypatch.setattr(
"atst.domain.csp.files.MockFileService.download_task_order",
_download_task_order,
)
task_order = TaskOrderFactory.create(create_clins=[{"number": "0002"}])
dispatch_send_task_order_files.run()
task_order = TaskOrderFactory.create(create_clins=[{"number": "0001"}]) # Check that pdf_last_sent_at has not been updated
dispatch_send_task_order_files.run() assert not task_order.pdf_last_sent_at
# Check that pdf_last_sent_at has not been updated
assert not task_order.pdf_last_sent_at
def test_dispatch_send_task_order_files_download_failure(monkeypatch):
mock = Mock()
monkeypatch.setattr("atst.jobs.send_mail", mock)
def _download_task_order(MockFileService, object_name):
raise AzureError("something went wrong")
monkeypatch.setattr(
"atst.domain.csp.files.MockFileService.download_task_order",
_download_task_order,
)
task_order = TaskOrderFactory.create(create_clins=[{"number": "0002"}])
dispatch_send_task_order_files.run()
# Check that pdf_last_sent_at has not been updated
assert not task_order.pdf_last_sent_at