From b807d2c932ee1138c00b3864d184ffe696c398da Mon Sep 17 00:00:00 2001
From: Patrick Smith <patrick+dds@promptworks.com>
Date: Fri, 11 Jan 2019 11:01:57 -0500
Subject: [PATCH] Clean up document links on task order view page

---
 styles/elements/_icon_link.scss            |  5 ++++
 styles/sections/_task_order.scss           | 29 +++------------------
 templates/workspaces/task_orders/show.html | 30 ++++++++++------------
 3 files changed, 21 insertions(+), 43 deletions(-)

diff --git a/styles/elements/_icon_link.scss b/styles/elements/_icon_link.scss
index c4543b38..88e340ff 100644
--- a/styles/elements/_icon_link.scss
+++ b/styles/elements/_icon_link.scss
@@ -63,4 +63,9 @@
   &.icon-link--default {
     @include icon-link-color($color-black-light, $color-gray-lightest);
   }
+
+  &.icon-link--disabled {
+    opacity: 0.3;
+    pointer-events: none;
+  }
 }
diff --git a/styles/sections/_task_order.scss b/styles/sections/_task_order.scss
index 2e595ed0..3845edac 100644
--- a/styles/sections/_task_order.scss
+++ b/styles/sections/_task_order.scss
@@ -77,36 +77,13 @@
   }
 
   .task-order-document-link {
-    &.disabled {
-      color: $color-shadow;
-      .task-order-document-link__icon {
-        span {
-          @include icon-color($color-cool-blue-lighter);
-        }
-      }
-    }
-
     .task-order-document-link__icon {
       padding-top: 0.5rem;
-      span {
-        @include icon-color($color-blue);
-      }
     }
 
-    .task-order-document-details {
-      .task-order-document-details__description {
-        font-style: italic;
-      }
-
-      .task-order-document-details__disabled_link {
-        @include icon-link;
-        cursor: unset;
-        &:hover {
-          background-color: unset;
-          color: $color-cool-blue-lighter;
-        }
-        color: $color-cool-blue-lighter;
-      }
+    .task-order-document-description {
+      padding-left: 3rem;
+      font-style: italic;
     }
   }
 
diff --git a/templates/workspaces/task_orders/show.html b/templates/workspaces/task_orders/show.html
index 40a78237..1ea2d3a7 100644
--- a/templates/workspaces/task_orders/show.html
+++ b/templates/workspaces/task_orders/show.html
@@ -28,26 +28,22 @@
 
 {% macro DocumentLink(title="", link_url="", description="") %}
   {% set disabled = not link_url %}
-  <div class="task-order-document-link row {{ 'disabled' if disabled }}">
-    <div class="task-order-document-link__icon col">
-      <span>{{ Icon("download") }}</span>
-    </div>
-    <div class="task-order-document-details col">
-      {% if disabled %}
-        <div class="task-order-document-details__disabled_link">
+  <div class="task-order-document-link">
+    <div class="row">
+      <a href="{{ link_url }}" class="icon-link {{ 'icon-link--disabled' if disabled }}" aria-disabled="{{ 'true' if disabled else 'false' }}">
+        <div class="task-order-document-link__icon col">
+          <span>{{ Icon("download") }}</span>
+        </div>
+        <div class="task-order-document-title col">
           {{ title }}
         </div>
-      {% else %}
-        <a href="{{ link_url }}" class="icon-link">
-          {{ title }}
-        </a>
-      {% endif %}
-      {% if description %}
-        <div class="task-order-document-details__description">
-          {{ description }}
-        </div>
-      {% endif %}
+      </a>
     </div>
+    {% if description %}
+      <div class="task-order-document-description">
+        {{ description }}
+      </div>
+    {% endif %}
   </div>
 {% endmacro %}