pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify WorkspaceRoles.get_by_id

Browse Source
This commit is contained in:
richard-dds 2018-11-27 14:17:42 -05:00
parent 218ec5d66a
commit b7c7c72a34
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
atst/domain/workspace_roles.py
View File

@ -36,16 +36,9 @@ class WorkspaceRoles(object):
@classmethod @classmethod
def get_by_id(cls, id_): def get_by_id(cls, id_):
try: try:
workspace_role = ( return db.session.query(WorkspaceRole).filter(WorkspaceRole.id == id_).one()
db.session.query(WorkspaceRole)
.join(User)
.filter(WorkspaceRole.id == id_)
.one()
)
except NoResultFound: except NoResultFound:
workspace_role = None raise NotFoundError("workspace_role")
return workspace_role
@classmethod @classmethod
def _get_active_workspace_role(cls, workspace_id, user_id): def _get_active_workspace_role(cls, workspace_id, user_id):