From 8be65316a55bead7ae7658da303d57342c068a72 Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:12:06 -0400 Subject: [PATCH 01/10] Add workspace_id vars to views --- atst/handlers/workspace.py | 2 +- atst/handlers/workspace_members.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/atst/handlers/workspace.py b/atst/handlers/workspace.py index 5a1f80ec..a14458a6 100644 --- a/atst/handlers/workspace.py +++ b/atst/handlers/workspace.py @@ -12,4 +12,4 @@ class Workspace(BaseHandler): @tornado.gen.coroutine def get(self, workspace_id): projects = self.projects_repo.get_many(workspace_id) - self.render("workspace.html.to", projects=projects) + self.render("workspace_projects.html.to", workspace_id=workspace_id, projects=projects) diff --git a/atst/handlers/workspace_members.py b/atst/handlers/workspace_members.py index c9b12fdf..9ffa7958 100644 --- a/atst/handlers/workspace_members.py +++ b/atst/handlers/workspace_members.py @@ -12,4 +12,4 @@ class WorkspaceMembers(BaseHandler): @tornado.gen.coroutine def get(self, workspace_id): members = self.members_repo.get_many(workspace_id) - self.render("workspace_members.html.to", members=members) + self.render("workspace_members.html.to", workspace_id=workspace_id, members=members) From 0e7cd537a55273e5989029f3d4bd19da65fd6569 Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:12:26 -0400 Subject: [PATCH 02/10] rename layout partial --- scss/atat.scss | 2 +- scss/components/{_layout.scss => _global_layout.scss} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename scss/components/{_layout.scss => _global_layout.scss} (100%) diff --git a/scss/atat.scss b/scss/atat.scss index e282ef53..a45a86cf 100644 --- a/scss/atat.scss +++ b/scss/atat.scss @@ -16,8 +16,8 @@ @import 'elements/labels'; @import 'elements/diff'; -@import 'components/layout'; @import 'components/topbar'; +@import 'components/global_layout'; @import 'components/global_navigation'; @import 'components/site_action'; @import 'components/empty_state'; diff --git a/scss/components/_layout.scss b/scss/components/_global_layout.scss similarity index 100% rename from scss/components/_layout.scss rename to scss/components/_global_layout.scss From 2e5c6f7110b60785aa964b2d4df079e582b97c40 Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:12:47 -0400 Subject: [PATCH 03/10] Add workspace id to topbar --- templates/navigation/topbar.html.to | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/navigation/topbar.html.to b/templates/navigation/topbar.html.to index eb7a6499..207f5ecd 100644 --- a/templates/navigation/topbar.html.to +++ b/templates/navigation/topbar.html.to @@ -6,7 +6,7 @@
- {{ "Workspace Name" if context == 'workspace' else "JEDI" }} + {{ "Workspace "+workspace_id if context == 'workspace' else "JEDI" }} {% module Icon('caret_down', classes='topbar__link-icon icon--tiny') %} From 862f1f7b181300c017564d27430dc5cf2aa1e765 Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:16:25 -0400 Subject: [PATCH 04/10] change workspace projects URL --- atst/app.py | 2 +- templates/workspaces.html.to | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/atst/app.py b/atst/app.py index 37140abb..5025ffc3 100644 --- a/atst/app.py +++ b/atst/app.py @@ -121,7 +121,7 @@ def make_app(config, deps, **kwargs): url(r"/reports", Main, {"page": "reports"}, name="reports"), url(r"/calculator", Main, {"page": "calculator"}, name="calculator"), url(r"/workspaces/(\S+)/members", WorkspaceMembers, {}, name="workspace_members"), - url(r"/workspaces/(\S+)", Workspace, {}, name="workspace"), + url(r"/workspaces/(\S+)/projects", Workspace, {}, name="workspace_projects"), ] if not ENV == "production": diff --git a/templates/workspaces.html.to b/templates/workspaces.html.to index efd63fa7..6e7e7931 100644 --- a/templates/workspaces.html.to +++ b/templates/workspaces.html.to @@ -14,7 +14,7 @@ {% for w in workspaces %} - {{ w['name'] }}
+ {{ w['name'] }}
Task Order: #{{ w['task_order']['number'] }} From 72b67d3a554833d9b825b84e5b578414d8e8cde9 Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:16:39 -0400 Subject: [PATCH 05/10] path matcher can work with regex --- atst/ui_methods.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atst/ui_methods.py b/atst/ui_methods.py index 7347a412..cc93a14e 100644 --- a/atst/ui_methods.py +++ b/atst/ui_methods.py @@ -8,7 +8,7 @@ def dev(self): return os.getenv("TORNADO_ENV", "dev") == "dev" def matchesPath(self, href): - return self.request.uri.startswith(href) + return re.match('^'+href, self.request.uri) def modal(self, body): return self.render_string( From 7c13d92cb0d4be87a42c4b83b9dc35d964870091 Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:18:22 -0400 Subject: [PATCH 06/10] workspace navigation --- .../navigation/workspace_navigation.html.to | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/templates/navigation/workspace_navigation.html.to b/templates/navigation/workspace_navigation.html.to index cd325bcf..93ab38b1 100644 --- a/templates/navigation/workspace_navigation.html.to +++ b/templates/navigation/workspace_navigation.html.to @@ -1 +1,21 @@ -nav + From cd355b0ed7fa7704b03c14e34088da740c3029be Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:18:41 -0400 Subject: [PATCH 07/10] workspace layout --- scss/components/_workspace_layout.scss | 26 ++++++++++++++++++++++++++ templates/base_workspace.html.to | 10 ++++++++-- 2 files changed, 34 insertions(+), 2 deletions(-) create mode 100644 scss/components/_workspace_layout.scss diff --git a/scss/components/_workspace_layout.scss b/scss/components/_workspace_layout.scss new file mode 100644 index 00000000..e2cf4c24 --- /dev/null +++ b/scss/components/_workspace_layout.scss @@ -0,0 +1,26 @@ +.workspace-panel-container { + @include media($large-screen) { + @include grid-row; + } +} + +.workspace-navigation { + @include panel-margin; + + ul { + display: flex; + flex-wrap: wrap; + li { + flex-grow: 1; + } + } + + @include media($large-screen) { + width: 20rem; + margin-right: $gap * 2; + + ul { + display: block; + } + } +} diff --git a/templates/base_workspace.html.to b/templates/base_workspace.html.to index 9622032f..7803ace8 100644 --- a/templates/base_workspace.html.to +++ b/templates/base_workspace.html.to @@ -2,8 +2,14 @@ {% block content %} - {% include 'navigation/workspace_navigation.html.to' %} +
+
+ {% include 'navigation/workspace_navigation.html.to' %} +
- {% block workspace_content %}{% end %} +
+ {% block workspace_content %}{% end %} +
+
{% end %} From 1de0672910ebd478e4a566f301458035987aa753 Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:18:58 -0400 Subject: [PATCH 08/10] rename to workpsace projects --- templates/{workspace.html.to => workspace_projects.html.to} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename templates/{workspace.html.to => workspace_projects.html.to} (100%) diff --git a/templates/workspace.html.to b/templates/workspace_projects.html.to similarity index 100% rename from templates/workspace.html.to rename to templates/workspace_projects.html.to From 6bea03d7a6d56e883ef37a4ece1d6b0faff106d2 Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:19:07 -0400 Subject: [PATCH 09/10] imports --- scss/atat.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/scss/atat.scss b/scss/atat.scss index a45a86cf..a2f91592 100644 --- a/scss/atat.scss +++ b/scss/atat.scss @@ -19,6 +19,7 @@ @import 'components/topbar'; @import 'components/global_layout'; @import 'components/global_navigation'; +@import 'components/workspace_layout'; @import 'components/site_action'; @import 'components/empty_state'; @import 'components/alerts'; From 1dd01a0ce9925edc1a2e9aca91a6af4e04b680cc Mon Sep 17 00:00:00 2001 From: Andrew Croce Date: Fri, 27 Jul 2018 10:19:22 -0400 Subject: [PATCH 10/10] workspace members page extends base_workspace --- templates/workspace_members.html.to | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/workspace_members.html.to b/templates/workspace_members.html.to index 9d66ee83..a38f653e 100644 --- a/templates/workspace_members.html.to +++ b/templates/workspace_members.html.to @@ -1,6 +1,6 @@ -{% extends "base.html.to" %} +{% extends "base_workspace.html.to" %} -{% block content %} +{% block workspace_content %}