pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move action_required_by to Request model

Browse Source
This commit is contained in:
richard-dds 2018-09-04 14:18:25 -04:00
parent 762a44d9ab
commit b18b238649
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
atst/domain/requests.py
View File

@ -153,14 +153,6 @@ class Requests(object):
request.status_events.append(status_event) request.status_events.append(status_event)
return request return request
@classmethod
def action_required_by(cls, request):
return {
RequestStatus.STARTED: "mission_owner",
RequestStatus.PENDING_FINANCIAL_VERIFICATION: "mission_owner",
RequestStatus.PENDING_CCPO_APPROVAL: "ccpo",
}.get(request.status)
@classmethod @classmethod
def should_auto_approve(cls, request): def should_auto_approve(cls, request):
try: try:

8
atst/models/request.py
View File

@ -60,3 +60,11 @@ class Request(Base):
if last_submission: if last_submission:
return pendulum.instance(last_submission.time_created) return pendulum.instance(last_submission.time_created)
return None return None
@property
def action_required_by(self):
return {
RequestStatus.STARTED: "mission_owner",
RequestStatus.PENDING_FINANCIAL_VERIFICATION: "mission_owner",
RequestStatus.PENDING_CCPO_APPROVAL: "ccpo",
}.get(self.status)

6
tests/models/test_requests.py
View File

@ -4,21 +4,21 @@ from atst.domain.requests import Requests, RequestStatus
def test_started_request_requires_mo_action(): def test_started_request_requires_mo_action():
request = RequestFactory.create() request = RequestFactory.create()
assert Requests.action_required_by(request) == "mission_owner" assert request.action_required_by == "mission_owner"
def test_pending_financial_requires_mo_action(): def test_pending_financial_requires_mo_action():
request = RequestFactory.create() request = RequestFactory.create()
request = Requests.set_status(request, RequestStatus.PENDING_FINANCIAL_VERIFICATION) request = Requests.set_status(request, RequestStatus.PENDING_FINANCIAL_VERIFICATION)
assert Requests.action_required_by(request) == "mission_owner" assert request.action_required_by == "mission_owner"
def test_pending_ccpo_approval_requires_ccpo(): def test_pending_ccpo_approval_requires_ccpo():
request = RequestFactory.create() request = RequestFactory.create()
request = Requests.set_status(request, RequestStatus.PENDING_CCPO_APPROVAL) request = Requests.set_status(request, RequestStatus.PENDING_CCPO_APPROVAL)
assert Requests.action_required_by(request) == "ccpo" assert request.action_required_by == "ccpo"
def test_request_has_creator(): def test_request_has_creator():