From b17741acd1e4d5903d3685927561afdec61913c0 Mon Sep 17 00:00:00 2001
From: dandds <dan-ctr@friends.dds.mil>
Date: Mon, 8 Apr 2019 14:00:26 -0400
Subject: [PATCH] Adds an ORM permission set listener for application roles.

Application role changes will be recorded in the audit log. Generalizes
pre-existing listener that was in user for portfolio roles.
---
 atst/models/application_role.py       | 10 +++++++
 atst/models/mixins/auditable.py       | 15 ++++++++++
 atst/models/portfolio_role.py         | 25 ++++++-----------
 tests/models/test_application_role.py | 40 +++++++++++++++++++++++++++
 4 files changed, 74 insertions(+), 16 deletions(-)
 create mode 100644 tests/models/test_application_role.py

diff --git a/atst/models/application_role.py b/atst/models/application_role.py
index dc0db4d1..054006cc 100644
--- a/atst/models/application_role.py
+++ b/atst/models/application_role.py
@@ -2,8 +2,10 @@ from enum import Enum
 from sqlalchemy import Index, ForeignKey, Column, Enum as SQLAEnum, Table
 from sqlalchemy.dialects.postgresql import UUID
 from sqlalchemy.orm import relationship
+from sqlalchemy.event import listen
 
 from atst.models import Base, mixins
+from atst.models.mixins.auditable import record_permission_sets_updates
 from .types import Id
 
 
@@ -56,3 +58,11 @@ Index(
     ApplicationRole.application_id,
     unique=True,
 )
+
+
+listen(
+    ApplicationRole.permission_sets,
+    "bulk_replace",
+    record_permission_sets_updates,
+    raw=True,
+)
diff --git a/atst/models/mixins/auditable.py b/atst/models/mixins/auditable.py
index f0487dad..091dc411 100644
--- a/atst/models/mixins/auditable.py
+++ b/atst/models/mixins/auditable.py
@@ -98,3 +98,18 @@ class AuditableMixin(object):
     @property
     def displayname(self):
         return None
+
+
+def record_permission_sets_updates(instance_state, permission_sets, initiator):
+    old_perm_sets = instance_state.attrs.get("permission_sets").value
+    if instance_state.persistent and old_perm_sets != permission_sets:
+        connection = instance_state.session.connection()
+        old_state = [p.name for p in old_perm_sets]
+        new_state = [p.name for p in permission_sets]
+        changed_state = {"permission_sets": (old_state, new_state)}
+        instance_state.object.create_audit_event(
+            connection,
+            instance_state.object,
+            ACTION_UPDATE,
+            changed_state=changed_state,
+        )
diff --git a/atst/models/portfolio_role.py b/atst/models/portfolio_role.py
index c7eb7f2d..adb1017a 100644
--- a/atst/models/portfolio_role.py
+++ b/atst/models/portfolio_role.py
@@ -1,7 +1,8 @@
 from enum import Enum
-from sqlalchemy import Index, ForeignKey, Column, Enum as SQLAEnum, Table, event
+from sqlalchemy import Index, ForeignKey, Column, Enum as SQLAEnum, Table
 from sqlalchemy.dialects.postgresql import UUID
 from sqlalchemy.orm import relationship
+from sqlalchemy.event import listen
 
 from atst.models import Base, mixins
 from .types import Id
@@ -11,7 +12,7 @@ from atst.utils import first_or_none
 from atst.models.environment_role import EnvironmentRole
 from atst.models.application import Application
 from atst.models.environment import Environment
-from atst.models.mixins.auditable import ACTION_UPDATE as AUDIT_ACTION_UPDATE
+from atst.models.mixins.auditable import record_permission_sets_updates
 
 
 MEMBER_STATUSES = {
@@ -168,17 +169,9 @@ Index(
 )
 
 
-@event.listens_for(PortfolioRole.permission_sets, "bulk_replace", raw=True)
-def record_permission_sets_updates(instance_state, permission_sets, initiator):
-    old_perm_sets = instance_state.attrs.get("permission_sets").value
-    if instance_state.persistent and old_perm_sets != permission_sets:
-        connection = instance_state.session.connection()
-        old_state = [p.name for p in old_perm_sets]
-        new_state = [p.name for p in permission_sets]
-        changed_state = {"permission_sets": (old_state, new_state)}
-        instance_state.object.create_audit_event(
-            connection,
-            instance_state.object,
-            AUDIT_ACTION_UPDATE,
-            changed_state=changed_state,
-        )
+listen(
+    PortfolioRole.permission_sets,
+    "bulk_replace",
+    record_permission_sets_updates,
+    raw=True,
+)
diff --git a/tests/models/test_application_role.py b/tests/models/test_application_role.py
new file mode 100644
index 00000000..5bfc102c
--- /dev/null
+++ b/tests/models/test_application_role.py
@@ -0,0 +1,40 @@
+from atst.domain.permission_sets import PermissionSets
+from atst.models.audit_event import AuditEvent
+
+from tests.factories import PortfolioFactory, UserFactory
+
+
+def test_has_application_role_history(session):
+    owner = UserFactory.create()
+    user = UserFactory.create()
+
+    PortfolioFactory.create(
+        owner=owner,
+        applications=[
+            {
+                "name": "starkiller",
+                "environments": [
+                    {
+                        "name": "bridge",
+                        "members": [{"user": user, "role_name": "developer"}],
+                    }
+                ],
+            }
+        ],
+    )
+
+    app_role = user.application_roles[0]
+    app_role.permission_sets = [
+        PermissionSets.get(PermissionSets.EDIT_APPLICATION_TEAM)
+    ]
+    session.add(app_role)
+    session.commit()
+
+    changed_event = (
+        session.query(AuditEvent)
+        .filter(AuditEvent.resource_id == app_role.id, AuditEvent.action == "update")
+        .one()
+    )
+    old_state, new_state = changed_event.changed_state["permission_sets"]
+    assert old_state == [PermissionSets.VIEW_APPLICATION]
+    assert new_state == [PermissionSets.EDIT_APPLICATION_TEAM]