Keep test coverage, but skip front end tests for requests

tests/routes/requests/requests_form/test_details.py

@@ -1,4 +1,3 @@
-import pytest
 import re
 from flask import url_for
 
@@ -7,7 +6,6 @@ from atst.models.request_status_event import RequestStatus
 from tests.factories import RequestFactory, LegacyTaskOrderFactory, UserFactory
 
 
-@pytest.mark.requests_workflow
 def test_can_show_financial_data(client, user_session):
     user = UserFactory.create()
     user_session(user)
@@ -26,7 +24,6 @@ def test_can_show_financial_data(client, user_session):
     assert re.search(r">\s+Financial Verification\s+<", body)
 
 
-@pytest.mark.requests_workflow
 def test_can_not_show_financial_data(client, user_session):
     user = UserFactory.create()
     user_session(user)

tests/routes/requests/requests_form/test_edit.py

@@ -1,9 +1,7 @@
-import pytest
 from tests.factories import UserFactory, RequestFactory
 from atst.models.request_status_event import RequestStatus
 
 
-@pytest.mark.requests_workflow
 def test_creator_pending_finver(client, user_session):
     request = RequestFactory.create_with_status(
         RequestStatus.PENDING_FINANCIAL_VERIFICATION
@@ -15,7 +13,6 @@ def test_creator_pending_finver(client, user_session):
     assert "verify" in response.location
 
 
-@pytest.mark.requests_workflow
 def test_creator_pending_finver_changes(client, user_session):
     request = RequestFactory.create_with_status(
         RequestStatus.CHANGES_REQUESTED_TO_FINVER
@@ -27,7 +24,6 @@ def test_creator_pending_finver_changes(client, user_session):
     assert "verify" in response.location
 
 
-@pytest.mark.requests_workflow
 def test_creator_approved(client, user_session):
     request = RequestFactory.create_with_status(RequestStatus.APPROVED)
     user_session(request.creator)
@@ -37,7 +33,6 @@ def test_creator_approved(client, user_session):
     assert "details" in response.location
 
 
-@pytest.mark.requests_workflow
 def test_creator_approved(client, user_session):
     request = RequestFactory.create_with_status(RequestStatus.STARTED)
     user_session(request.creator)
@@ -47,7 +42,6 @@ def test_creator_approved(client, user_session):
     assert "new" in response.location
 
 
-@pytest.mark.requests_workflow
 def test_ccpo(client, user_session):
     ccpo = UserFactory.from_atat_role("ccpo")
     request = RequestFactory.create_with_status(RequestStatus.STARTED)

tests/routes/requests/requests_form/test_new.py

@@ -1,4 +1,3 @@
-import pytest
 import datetime
 import re
 from tests.factories import (
@@ -18,7 +17,6 @@ from tests.assert_util import dict_contains
 ERROR_CLASS = "alert--error"
 
 
-@pytest.mark.requests_workflow
 def test_submit_invalid_request_form(monkeypatch, client, user_session):
     user_session()
     response = client.post(
@@ -29,7 +27,6 @@ def test_submit_invalid_request_form(monkeypatch, client, user_session):
     assert re.search(ERROR_CLASS, response.data.decode())
 
 
-@pytest.mark.requests_workflow
 def test_submit_valid_request_form(monkeypatch, client, user_session):
     user_session()
     monkeypatch.setattr(
@@ -44,7 +41,6 @@ def test_submit_valid_request_form(monkeypatch, client, user_session):
     assert "/requests/new/2" in response.headers.get("Location")
 
 
-@pytest.mark.requests_workflow
 def test_owner_can_view_request(client, user_session):
     user = UserFactory.create()
     user_session(user)
@@ -57,7 +53,6 @@ def test_owner_can_view_request(client, user_session):
     assert response.status_code == 200
 
 
-@pytest.mark.requests_workflow
 def test_non_owner_cannot_view_request(client, user_session):
     user = UserFactory.create()
     user_session(user)
@@ -70,7 +65,6 @@ def test_non_owner_cannot_view_request(client, user_session):
     assert response.status_code == 404
 
 
-@pytest.mark.requests_workflow
 def test_ccpo_can_view_request(client, user_session):
     ccpo = Roles.get("ccpo")
     user = UserFactory.create(atat_role=ccpo)
@@ -84,7 +78,6 @@ def test_ccpo_can_view_request(client, user_session):
     assert response.status_code == 200
 
 
-@pytest.mark.requests_workflow
 def test_nonexistent_request(client, user_session):
     user_session()
     response = client.get("/requests/new/1/foo", follow_redirects=True)
@@ -92,7 +85,6 @@ def test_nonexistent_request(client, user_session):
     assert response.status_code == 404
 
 
-@pytest.mark.requests_workflow
 def test_creator_info_is_autopopulated_for_existing_request(
     monkeypatch, client, user_session
 ):
@@ -116,7 +108,6 @@ def test_creator_info_is_autopopulated_for_existing_request(
         assert "initial-value='{}'".format(value) in body
 
 
-@pytest.mark.requests_workflow
 def test_creator_info_is_autopopulated_for_new_request(
     monkeypatch, client, user_session
 ):
@@ -130,7 +121,6 @@ def test_creator_info_is_autopopulated_for_new_request(
     assert "initial-value='{}'".format(user.email) in body
 
 
-@pytest.mark.requests_workflow
 def test_non_creator_info_is_not_autopopulated(monkeypatch, client, user_session):
     user = UserFactory.create()
     creator = UserFactory.create()
@@ -144,7 +134,6 @@ def test_non_creator_info_is_not_autopopulated(monkeypatch, client, user_session
     assert not user.email in body
 
 
-@pytest.mark.requests_workflow
 def test_am_poc_causes_poc_to_be_autopopulated(client, user_session):
     creator = UserFactory.create()
     user_session(creator)
@@ -158,7 +147,6 @@ def test_am_poc_causes_poc_to_be_autopopulated(client, user_session):
     assert request.body["primary_poc"]["dodid_poc"] == creator.dod_id
 
 
-@pytest.mark.requests_workflow
 def test_not_am_poc_requires_poc_info_to_be_completed(client, user_session):
     creator = UserFactory.create()
     user_session(creator)
@@ -172,7 +160,6 @@ def test_not_am_poc_requires_poc_info_to_be_completed(client, user_session):
     assert ERROR_CLASS in response.data.decode()
 
 
-@pytest.mark.requests_workflow
 def test_not_am_poc_allows_user_to_fill_in_poc_info(client, user_session):
     creator = UserFactory.create()
     user_session(creator)
@@ -192,7 +179,6 @@ def test_not_am_poc_allows_user_to_fill_in_poc_info(client, user_session):
     assert ERROR_CLASS not in response.data.decode()
 
 
-@pytest.mark.requests_workflow
 def test_poc_details_can_be_autopopulated_on_new_request(client, user_session):
     creator = UserFactory.create()
     user_session(creator)
@@ -207,7 +193,6 @@ def test_poc_details_can_be_autopopulated_on_new_request(client, user_session):
     assert request.body["primary_poc"]["dodid_poc"] == creator.dod_id
 
 
-@pytest.mark.requests_workflow
 def test_poc_autofill_checks_information_about_you_form_first(client, user_session):
     creator = UserFactory.create()
     user_session(creator)
@@ -236,7 +221,6 @@ def test_poc_autofill_checks_information_about_you_form_first(client, user_sessi
     )
 
 
-@pytest.mark.requests_workflow
 def test_can_review_data(user_session, client):
     creator = UserFactory.create()
     user_session(creator)
@@ -248,7 +232,6 @@ def test_can_review_data(user_session, client):
     assert request.body["information_about_you"]["email_request"] in body
 
 
-@pytest.mark.requests_workflow
 def test_displays_ccpo_review_comment(user_session, client):
     creator = UserFactory.create()
     ccpo = UserFactory.from_atat_role("ccpo")

tests/routes/requests/requests_form/test_submit.py

@@ -8,7 +8,6 @@ def _mock_func(*args, **kwargs):
     return RequestFactory.create()
 
 
-@pytest.mark.requests_workflow
 def test_submit_reviewed_request(monkeypatch, client, user_session):
     user_session()
     monkeypatch.setattr("atst.domain.requests.Requests.get", _mock_func)
@@ -25,7 +24,6 @@ def test_submit_reviewed_request(monkeypatch, client, user_session):
     assert "modal=pendingCCPOAcceptance" in response.headers["Location"]
 
 
-@pytest.mark.requests_workflow
 def test_submit_autoapproved_reviewed_request(monkeypatch, client, user_session):
     user_session()
     monkeypatch.setattr("atst.domain.requests.Requests.get", _mock_func)