From aaa4b401b57be998f2945a05ece634c43c820066 Mon Sep 17 00:00:00 2001 From: tomdds Date: Tue, 4 Feb 2020 17:42:08 -0500 Subject: [PATCH] Fix LGTM issues --- atst/domain/csp/cloud/cloud_provider_interface.py | 2 +- atst/domain/csp/cloud/mock_cloud_provider.py | 5 ----- tests/domain/cloud/test_azure_csp.py | 12 +++++++++--- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/atst/domain/csp/cloud/cloud_provider_interface.py b/atst/domain/csp/cloud/cloud_provider_interface.py index d173396a..ac652b5c 100644 --- a/atst/domain/csp/cloud/cloud_provider_interface.py +++ b/atst/domain/csp/cloud/cloud_provider_interface.py @@ -11,7 +11,7 @@ class CloudProviderInterface: def root_creds(self) -> Dict: raise NotImplementedError() - def create_environment(self, auth_credentials: Dict, user, environment) -> str: + def create_environment(self, payload): """Create a new environment in the CSP. Arguments: diff --git a/atst/domain/csp/cloud/mock_cloud_provider.py b/atst/domain/csp/cloud/mock_cloud_provider.py index 4e4532d3..bb2f4941 100644 --- a/atst/domain/csp/cloud/mock_cloud_provider.py +++ b/atst/domain/csp/cloud/mock_cloud_provider.py @@ -452,11 +452,6 @@ class MockCloudProvider(CloudProviderInterface): id=f"{AZURE_MGMNT_PATH}{payload.management_group_name}" ) - def create_user(self, payload: UserCSPPayload): - self._maybe_raise(self.UNAUTHORIZED_RATE, GeneralCSPException) - - return UserCSPResult(id=str(uuid4())) - def create_environment(self, payload: EnvironmentCSPPayload): self._maybe_raise(self.UNAUTHORIZED_RATE, GeneralCSPException) diff --git a/tests/domain/cloud/test_azure_csp.py b/tests/domain/cloud/test_azure_csp.py index 8744ca5c..7ef1e67b 100644 --- a/tests/domain/cloud/test_azure_csp.py +++ b/tests/domain/cloud/test_azure_csp.py @@ -853,6 +853,7 @@ def test_get_reporting_data_malformed_payload(mock_azure: AzureCloudProvider): ) ) + def test_get_secret(mock_azure: AzureCloudProvider): with patch.object( AzureCloudProvider, @@ -861,10 +862,13 @@ def test_get_secret(mock_azure: AzureCloudProvider): ) as _get_client_secret_credential_obj: _get_client_secret_credential_obj.return_value = {} - mock_azure.sdk.secrets.SecretClient.return_value.get_secret.return_value.value = "my secret" + mock_azure.sdk.secrets.SecretClient.return_value.get_secret.return_value.value = ( + "my secret" + ) assert mock_azure.get_secret("secret key") == "my secret" + def test_set_secret(mock_azure: AzureCloudProvider): with patch.object( AzureCloudProvider, @@ -873,6 +877,8 @@ def test_set_secret(mock_azure: AzureCloudProvider): ) as _get_client_secret_credential_obj: _get_client_secret_credential_obj.return_value = {} - mock_azure.sdk.secrets.SecretClient.return_value.set_secret.return_value = "my secret" + mock_azure.sdk.secrets.SecretClient.return_value.set_secret.return_value = ( + "my secret" + ) - assert mock_azure.set_secret("secret key", "secret_value") == "my secret" \ No newline at end of file + assert mock_azure.set_secret("secret key", "secret_value") == "my secret"