pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add comments to explain test

Browse Source
This commit is contained in:
leigh-mil 2019-09-17 16:52:39 -04:00
parent cf172c486c
commit a7f9be5d48
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/routes/applications/test_settings.py
View File

@ -475,11 +475,13 @@ def test_remove_member_failure(client, user_session):
def test_update_member(client, user_session): def test_update_member(client, user_session):
role = PermissionSets.get(PermissionSets.EDIT_APPLICATION_TEAM) role = PermissionSets.get(PermissionSets.EDIT_APPLICATION_TEAM)
# create an app role with only edit team perms
app_role = ApplicationRoleFactory.create(permission_sets=[role]) app_role = ApplicationRoleFactory.create(permission_sets=[role])
application = app_role.application application = app_role.application
env = EnvironmentFactory.create(application=application) env = EnvironmentFactory.create(application=application)
env_1 = EnvironmentFactory.create(application=application) env_1 = EnvironmentFactory.create(application=application)
env_2 = EnvironmentFactory.create(application=application) env_2 = EnvironmentFactory.create(application=application)
# add user to two of the environments: env and env_1
EnvironmentRoleFactory.create( EnvironmentRoleFactory.create(
environment=env, application_role=app_role, role=CSPRole.BASIC_ACCESS.value environment=env, application_role=app_role, role=CSPRole.BASIC_ACCESS.value
) )
@ -488,7 +490,8 @@ def test_update_member(client, user_session):
) )
user_session(application.portfolio.owner) user_session(application.portfolio.owner)
# update the user's app permissions to have edit team and env perms
# update user's role in env, remove user from env_1, and add user to env_2
response = client.post( response = client.post(
url_for( url_for(
"applications.update_member", "applications.update_member",
@ -520,7 +523,9 @@ def test_update_member(client, user_session):
_external=True, _external=True,
) )
assert response.location == expected_url assert response.location == expected_url
# make sure new application role was not created
assert len(application.roles) == 1 assert len(application.roles) == 1
# check that new app perms were added
assert bool(app_role.has_permission_set(PermissionSets.EDIT_APPLICATION_TEAM)) assert bool(app_role.has_permission_set(PermissionSets.EDIT_APPLICATION_TEAM))
assert bool( assert bool(
app_role.has_permission_set(PermissionSets.EDIT_APPLICATION_ENVIRONMENTS) app_role.has_permission_set(PermissionSets.EDIT_APPLICATION_ENVIRONMENTS)
@ -530,6 +535,8 @@ def test_update_member(client, user_session):
) )
environment_roles = application.roles[0].environment_roles environment_roles = application.roles[0].environment_roles
# make sure that old env role was deleted and there are only 2 env roles
assert len(environment_roles) == 2 assert len(environment_roles) == 2
# check that the user has roles in the correct envs
assert environment_roles[0].environment in [env, env_2] assert environment_roles[0].environment in [env, env_2]
assert environment_roles[1].environment in [env, env_2] assert environment_roles[1].environment in [env, env_2]