From a0f6d98d28b28d5812f3bea729faa7ce6f63ec3c Mon Sep 17 00:00:00 2001 From: leigh-mil Date: Thu, 20 Jun 2019 13:48:33 -0400 Subject: [PATCH] Remove more unnecesary tests --- tests/routes/task_orders/test_new.py | 15 -------- tests/test_access.py | 53 ---------------------------- 2 files changed, 68 deletions(-) diff --git a/tests/routes/task_orders/test_new.py b/tests/routes/task_orders/test_new.py index f6d7a364..e7583258 100644 --- a/tests/routes/task_orders/test_new.py +++ b/tests/routes/task_orders/test_new.py @@ -184,18 +184,3 @@ def test_task_order_form_shows_errors(client, user_session, task_order): body = response.data.decode() assert "There were some errors" in body assert "Not a valid decimal" in body - - -@pytest.mark.skip(reason="Update after implementing new TO form") -def test_task_order_review_when_complete(client, user_session, task_order): - pass - - -@pytest.mark.skip(reason="Update after implementing new TO form") -def test_task_order_review_when_not_complete(client, user_session, task_order): - pass - - -@pytest.mark.skip(reason="Update after implementing new TO form") -def test_task_order_review_and_sign(client, user_session, task_order): - pass diff --git a/tests/test_access.py b/tests/test_access.py index 22519c05..84657cca 100644 --- a/tests/test_access.py +++ b/tests/test_access.py @@ -448,60 +448,7 @@ def test_task_orders_download_task_order_pdf_access(get_url_assert_status, monke get_url_assert_status(rando, url, 404) -# task_orders.edit -@pytest.mark.skip(reason="Update after new TO form implemented") -def test_task_orders_new_access(get_url_assert_status): - ccpo = user_with(PermissionSets.EDIT_PORTFOLIO_FUNDING) - owner = user_with() - rando = user_with() - portfolio = PortfolioFactory.create(owner=owner) - - url = url_for("task_orders.edit", portfolio_id=portfolio.id) - get_url_assert_status(owner, url, 200) - get_url_assert_status(ccpo, url, 200) - get_url_assert_status(rando, url, 404) - - -# task_orders.record_signature -@pytest.mark.skip(reason="Update after TO signature is reimplemented") -def test_task_orders_record_signature_access(post_url_assert_status, monkeypatch): - ccpo = UserFactory.create_ccpo() - owner = user_with() - rando = user_with() - - portfolio = PortfolioFactory.create(owner=owner) - task_order = TaskOrderFactory.create(portfolio=portfolio) - monkeypatch.setattr( - "atst.routes.task_orders.signing.find_unsigned_ko_to", lambda *a: task_order - ) - - url = url_for("task_orders.record_signature", task_order_id=task_order.id) - post_url_assert_status(owner, url, 404) - post_url_assert_status(ccpo, url, 404) - post_url_assert_status(rando, url, 404) - - -# task_orders.signature_requested -@pytest.mark.skip(reason="Update after TO signature is reimplemented") -def test_task_orders_signature_requested_access(get_url_assert_status, monkeypatch): - ccpo = UserFactory.create_ccpo() - owner = user_with() - rando = user_with() - - portfolio = PortfolioFactory.create(owner=owner) - task_order = TaskOrderFactory.create(portfolio=portfolio) - monkeypatch.setattr( - "atst.routes.task_orders.signing.find_unsigned_ko_to", lambda *a: task_order - ) - - url = url_for("task_orders.record_signature", task_order_id=task_order.id) - get_url_assert_status(owner, url, 404) - get_url_assert_status(ccpo, url, 404) - get_url_assert_status(rando, url, 404) - - # task_orders.update -@pytest.mark.skip(reason="Update after TO form is fixed") def test_task_orders_update_access(post_url_assert_status): ccpo = user_with(PermissionSets.EDIT_PORTFOLIO_FUNDING) owner = user_with()