Remove user.provisional column.

This is leftover from a previous iteration of ATAT where inviting a user
to a portfolio would create a pending entry in the users table. This is
no longer used.

alembic/versions/5d7198d34b91_remove_users_provisional.py

@@ -0,0 +1,28 @@
+"""remove users.provisional
+
+Revision ID: 5d7198d34b91
+Revises: 02ac8bdcf16f
+Create Date: 2020-01-09 08:42:34.512191
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+
+# revision identifiers, used by Alembic.
+revision = '5d7198d34b91' # pragma: allowlist secret
+down_revision = '02ac8bdcf16f' # pragma: allowlist secret
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_column('users', 'provisional')
+    # ### end Alembic commands ###
+
+
+def downgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.add_column('users', sa.Column('provisional', sa.BOOLEAN(), autoincrement=False, nullable=True))
+    # ### end Alembic commands ###

atst/domain/users.py

@@ -117,12 +117,3 @@ class Users(object):
         user.last_session_id = session_id
         db.session.add(user)
         db.session.commit()
-
-    @classmethod
-    def finalize(cls, user):
-        user.provisional = False
-
-        db.session.add(user)
-        db.session.commit()
-
-        return user

atst/models/user.py

@@ -1,4 +1,4 @@
-from sqlalchemy import String, ForeignKey, Column, Date, Boolean, Table, TIMESTAMP
+from sqlalchemy import String, ForeignKey, Column, Date, Table, TIMESTAMP
 from sqlalchemy.orm import relationship
 from sqlalchemy.dialects.postgresql import UUID
 from sqlalchemy.event import listen
@@ -67,8 +67,6 @@ class User(
     last_login = Column(TIMESTAMP(timezone=True), nullable=True)
     last_session_id = Column(UUID(as_uuid=True), nullable=True)
 
-    provisional = Column(Boolean)
-
     cloud_id = Column(String)
 
     REQUIRED_FIELDS = [

atst/routes/__init__.py

@@ -98,9 +98,6 @@ def login_redirect():
     auth_context.authenticate()
     user = auth_context.get_user()
 
-    if user.provisional:
-        Users.finalize(user)
-
     current_user_setup(user)
     return redirect(redirect_after_login_url())