Clean up defunct upload and CRL logic.

- Applies our previous CSP namespacing pattern to the upload classes.
- Removes code and config for previous uploader implementation.
- Removes Attachment model's ability to upload files directly and
  adjusts tests that expected that behavior.

tests/domain/csp/test_files.py

@@ -1,75 +0,0 @@
-import os
-import pytest
-from werkzeug.datastructures import FileStorage
-from unittest.mock import Mock
-
-from atst.domain.csp.files import (
-    CSPFileError,
-    RackspaceFileProvider,
-    RackspaceCRLProvider,
-)
-from atst.domain.exceptions import UploadError
-
-from tests.mocks import PDF_FILENAME
-
-
-@pytest.fixture
-def uploader(app):
-    return RackspaceFileProvider(app)
-
-
-NONPDF_FILENAME = "tests/fixtures/disa-pki.html"
-
-
-def test_upload(app, uploader, pdf_upload):
-    object_name = uploader.upload(pdf_upload)
-    upload_dir = app.config["STORAGE_CONTAINER"]
-    assert os.path.isfile(os.path.join(upload_dir, object_name))
-
-
-def test_upload_fails_for_non_pdfs(uploader):
-    with open(NONPDF_FILENAME, "rb") as fp:
-        fs = FileStorage(fp, content_type="text/plain")
-        with pytest.raises(UploadError):
-            uploader.upload(fs)
-
-
-def test_download(app, uploader, pdf_upload):
-    # write pdf content to upload file storage and make sure it is flushed to
-    # disk
-    pdf_upload.seek(0)
-    pdf_content = pdf_upload.read()
-    pdf_upload.close()
-    upload_dir = app.config["STORAGE_CONTAINER"]
-    full_path = os.path.join(upload_dir, "abc")
-    with open(full_path, "wb") as output_file:
-        output_file.write(pdf_content)
-        output_file.flush()
-
-    stream = uploader.download("abc")
-    stream_content = b"".join([b for b in stream])
-    assert pdf_content == stream_content
-
-
-def test_downloading_uploaded_object(uploader, pdf_upload):
-    object_name = uploader.upload(pdf_upload)
-    stream = uploader.download(object_name)
-    stream_content = b"".join([b for b in stream])
-
-    pdf_upload.seek(0)
-    pdf_content = pdf_upload.read()
-
-    assert stream_content == pdf_content
-
-
-def test_crl_download_fails(app, monkeypatch):
-    mock_object = Mock()
-    mock_object.download.return_value = False
-    monkeypatch.setattr(
-        "atst.domain.csp.files.RackspaceCRLProvider.object", mock_object
-    )
-
-    rs_crl_provider = RackspaceCRLProvider(app)
-
-    with pytest.raises(CSPFileError):
-        rs_crl_provider.sync_crls()

tests/domain/test_task_orders.py

@@ -75,7 +75,7 @@ def test_task_order_sorting():
     assert TaskOrders.sort(task_orders) == task_orders
 
 
-def test_create_adds_clins(pdf_upload):
+def test_create_adds_clins():
     portfolio = PortfolioFactory.create()
     clins = [
         {
@@ -100,12 +100,12 @@ def test_create_adds_clins(pdf_upload):
         portfolio_id=portfolio.id,
         number="0123456789",
         clins=clins,
-        pdf=pdf_upload,
+        pdf={"filename": "sample.pdf", "object_name": "1234567"},
     )
     assert len(task_order.clins) == 2
 
 
-def test_update_adds_clins(pdf_upload):
+def test_update_adds_clins():
     task_order = TaskOrderFactory.create(number="1231231234")
     to_number = task_order.number
     clins = [
@@ -131,13 +131,13 @@ def test_update_adds_clins(pdf_upload):
         portfolio_id=task_order.portfolio_id,
         number="0000000000",
         clins=clins,
-        pdf=pdf_upload,
+        pdf={"filename": "sample.pdf", "object_name": "1234567"},
     )
     assert task_order.number != to_number
     assert len(task_order.clins) == 2
 
 
-def test_update_does_not_duplicate_clins(pdf_upload):
+def test_update_does_not_duplicate_clins():
     task_order = TaskOrderFactory.create(
         number="3453453456", create_clins=["123", "456"]
     )
@@ -160,7 +160,10 @@ def test_update_does_not_duplicate_clins(pdf_upload):
         },
     ]
     task_order = TaskOrders.update(
-        task_order_id=task_order.id, number="0000000000", clins=clins, pdf=pdf_upload
+        task_order_id=task_order.id,
+        number="0000000000",
+        clins=clins,
+        pdf={"filename": "sample.pdf", "object_name": "1234567"},
     )
     assert len(task_order.clins) == 2
     for clin in task_order.clins: