From 9e5d3094d02616a916b031c221b169db41dc10fb Mon Sep 17 00:00:00 2001 From: richard-dds Date: Mon, 10 Sep 2018 13:46:20 -0400 Subject: [PATCH] Extract variable for readability --- atst/domain/workspaces/scopes.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/atst/domain/workspaces/scopes.py b/atst/domain/workspaces/scopes.py index 640f75cf..3a719239 100644 --- a/atst/domain/workspaces/scopes.py +++ b/atst/domain/workspaces/scopes.py @@ -30,9 +30,11 @@ class ScopedWorkspace(ScopedResource): @property def projects(self): - if Authorization.has_workspace_permission( + can_view_all_projects = Authorization.has_workspace_permission( self.user, self.resource, Permissions.VIEW_APPLICATION_IN_WORKSPACE - ): + ) + + if can_view_all_projects: projects = self.resource.projects else: projects = Projects.for_user(self.user, self.resource) @@ -49,9 +51,11 @@ class ScopedProject(ScopedResource): @property def environments(self): - if Authorization.has_workspace_permission( + can_view_all_environments = Authorization.has_workspace_permission( self.user, self.resource, Permissions.VIEW_ENVIRONMENT_IN_APPLICATION - ): + ) + + if can_view_all_environments: environments = self.resource.environments else: environments = Environments.for_user(self.user, self.resource)