pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use separate queue method for notifications

Browse Source
This commit is contained in:
richard-dds 2019-05-15 11:16:48 -04:00
parent 9e97df79f5
commit 9ba1def91c
4 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
atst/queue.py
View File

@ -30,6 +30,9 @@ class ATSTQueue(RQ):
def send_mail(self, recipients, subject, body): def send_mail(self, recipients, subject, body):
self._queue_job(ATSTQueue._send_mail, recipients, subject, body) self._queue_job(ATSTQueue._send_mail, recipients, subject, body)
def send_notification_mail(self, recipients, subject, body):
self._queue_job(ATSTQueue._send_mail, recipients, subject, body)
# pylint: disable=pointless-string-statement # pylint: disable=pointless-string-statement
"""Class methods to actually perform the work. """Class methods to actually perform the work.

2
atst/utils/notification_sender.py
View File

@ -20,7 +20,7 @@ class NotificationSender(object):
recipients, body recipients, body
) )
) )
self.queue.send_mail(recipients, self.EMAIL_SUBJECT, body) self.queue.send_notification_mail(recipients, self.EMAIL_SUBJECT, body)
def _get_recipients(self, type_): def _get_recipients(self, type_):
query = select([NotificationRecipient.email]) query = select([NotificationRecipient.email])

2
tests/conftest.py
View File

@ -310,7 +310,7 @@ def mock_logger(app):
@pytest.fixture @pytest.fixture
def mock_notification_sender(app): def notification_sender(app):
real_notification_sender = app.notification_sender real_notification_sender = app.notification_sender
app.notification_sender = FakeNotificationSender() app.notification_sender = FakeNotificationSender()

2
tests/utils/test_notification_sender.py
View File

@ -22,6 +22,6 @@ def test_can_send_notification(mock_queue, notification_sender):
NotificationRecipientFactory.create(email=recipient_email) NotificationRecipientFactory.create(email=recipient_email)
notification_sender.send(email_body) notification_sender.send(email_body)
mock_queue.send_mail.assert_called_once_with( mock_queue.send_notification_mail.assert_called_once_with(
("test@example.com",), notification_sender.EMAIL_SUBJECT, email_body ("test@example.com",), notification_sender.EMAIL_SUBJECT, email_body
) )