pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable rather than delete application_roles

Browse Source
This commit is contained in:
George Drummond 2019-05-14 15:26:51 -04:00
parent b884c8a762
commit 9927b22783
No known key found for this signature in database
GPG Key ID: 296DD6077123BF17
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
atst/domain/applications.py
View File

@ -108,7 +108,8 @@ class Applications(BaseDomainClass):
user_id=user_id, application_id=application.id user_id=user_id, application_id=application.id
) )
db.session.delete(application_role) application_role.status = ApplicationRoleStatus.DISABLED
db.session.add(application_role)
db.session.commit() db.session.commit()
for env in application.environments: for env in application.environments:

6
tests/domain/test_applications.py
View File

@ -173,8 +173,10 @@ def test_remove_member():
Applications.remove_member(application=application, user_id=member_role.user.id) Applications.remove_member(application=application, user_id=member_role.user.id)
with pytest.raises(NotFoundError): assert (
ApplicationRoles.get(user_id=user.id, application_id=application.id) ApplicationRoles.get(user_id=user.id, application_id=application.id).status
== ApplicationRoleStatus.DISABLED
)
# #
# TODO: Why does above raise NotFoundError and this returns None # TODO: Why does above raise NotFoundError and this returns None