Hide Budget Report from admins and developers

atst/domain/roles.py

@@ -119,7 +119,6 @@ WORKSPACE_ROLES = [
         "description": "Views only the projects and environments they are granted access to. Can also view members associated with each environment.",
         "permissions": [
             Permissions.VIEW_USAGE_REPORT,
-            Permissions.VIEW_USAGE_DOLLARS,
             Permissions.VIEW_WORKSPACE,
             Permissions.VIEW_APPLICATION_IN_WORKSPACE,
         ],

tests/routes/test_workspaces.py

@@ -9,6 +9,30 @@ from atst.domain.environment_roles import EnvironmentRoles
 from atst.models.workspace_user import WorkspaceUser
 
 
+def test_user_with_permission_has_budget_report_link(client, user_session):
+    user = UserFactory.create()
+    workspace = WorkspaceFactory.create()
+    Workspaces._create_workspace_role(user, workspace, "owner")
+
+    user_session(user)
+    response = client.get("/workspaces/{}/projects".format(workspace.id))
+    assert (
+        'href="/workspaces/{}/reports"'.format(workspace.id).encode() in response.data
+    )
+
+
+def test_user_without_permission_has_no_budget_report_link(client, user_session):
+    user = UserFactory.create()
+    workspace = WorkspaceFactory.create()
+    Workspaces._create_workspace_role(user, workspace, "developer")
+    user_session(user)
+    response = client.get("/workspaces/{}/projects".format(workspace.id))
+    assert (
+        'href="/workspaces/{}/reports"'.format(workspace.id).encode()
+        not in response.data
+    )
+
+
 def test_user_with_permission_has_add_project_link(client, user_session):
     user = UserFactory.create()
     workspace = WorkspaceFactory.create()