From 94d86803618f1953360c6d6d8f70c114f90332cd Mon Sep 17 00:00:00 2001 From: dandds Date: Wed, 19 Jun 2019 10:39:42 -0400 Subject: [PATCH] Do not return deactivated portfolios in Portfolios.for_user --- atst/domain/portfolios/query.py | 1 + tests/domain/test_portfolios.py | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/atst/domain/portfolios/query.py b/atst/domain/portfolios/query.py index e215b9d3..86ff539f 100644 --- a/atst/domain/portfolios/query.py +++ b/atst/domain/portfolios/query.py @@ -48,6 +48,7 @@ class PortfoliosQuery(Query): ), ) ) + .filter(Portfolio.deleted == False) .order_by(Portfolio.name.asc()) .all() ) diff --git a/tests/domain/test_portfolios.py b/tests/domain/test_portfolios.py index 473f85de..87be0cb5 100644 --- a/tests/domain/test_portfolios.py +++ b/tests/domain/test_portfolios.py @@ -219,3 +219,9 @@ def test_delete_failure_with_applications(): Portfolios.delete(portfolio=portfolio) assert not portfolio.deleted + + +def test_for_user_does_not_include_deleted_portfolios(): + user = UserFactory.create() + PortfolioFactory.create(owner=user, deleted=True) + assert len(Portfolios.for_user(user)) == 0