Rename "choices" var to "role_choices" for clarity

atst/routes/workspaces.py

@@ -123,7 +123,7 @@ def workspace_members(workspace_id):
     return render_template(
         "workspaces/members/index.html",
         workspace=workspace,
-        choices=WORKSPACE_ROLE_DEFINITIONS,
+        role_choices=WORKSPACE_ROLE_DEFINITIONS,
         members=members_list,
         new_member=new_member,
     )

js/components/forms/members_list.js

@@ -51,7 +51,7 @@ export default {
 
   props: {
     members: Array,
-    choices: Array,
+    role_choices: Array,
   },
 
   data: function () {
@@ -91,7 +91,7 @@ export default {
       searchValue: '',
       status: '',
       role: '',
-      rolesByDisplayName: indexBy(prop('display_name'), this.choices),
+      rolesByDisplayName: indexBy(prop('display_name'), this.role_choices),
       sortInfo: {
         columnName: '',
         isAscending: true,

templates/workspaces/members/index.html

@@ -47,7 +47,7 @@
 {% endif %}
 
 
-<members-list inline-template id="search-template" v-bind:members='{{ members | tojson}}' v-bind:choices='{{ choices | tojson}}'>
+<members-list inline-template id="search-template" v-bind:members='{{ members | tojson}}' v-bind:role_choices='{{ role_choices | tojson}}'>
   <div>
   <form class='search-bar' @submit.prevent>
     <div class='usa-input search-input'>
@@ -72,7 +72,7 @@
       <select v-model="role" id="filter-role" name="filter-role">
         <option value="" selected disabled>Filter by role</option>
         <option value="all">View All</option>
-        {% for role in choices %}
+        {% for role in role_choices %}
           <option value='{{ role.name }}'>{{ role.display_name }}</option>
         {% endfor %}
       </select>