From 933d90b203ef31178d3914abd4d27701fd1b0b0f Mon Sep 17 00:00:00 2001 From: George Drummond Date: Mon, 1 Apr 2019 13:32:11 -0400 Subject: [PATCH] Save PR and don't do an extra lookup --- tests/domain/test_authz.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/domain/test_authz.py b/tests/domain/test_authz.py index 37749533..bfebe562 100644 --- a/tests/domain/test_authz.py +++ b/tests/domain/test_authz.py @@ -76,7 +76,7 @@ def test_user_can_access(): portfolio = PortfolioFactory.create(owner=edit_admin) # factory gives view perms by default - PortfolioRoleFactory.create(user=view_admin, portfolio=portfolio) + view_admin_pr = PortfolioRoleFactory.create(user=view_admin, portfolio=portfolio) # check a site-wide permission assert user_can_access(ccpo, Permissions.VIEW_AUDIT_LOG) @@ -103,7 +103,6 @@ def test_user_can_access(): ) # check when portfolio_role is disabled - view_admin_pr = PortfolioRoles.get(portfolio_id=portfolio.id, user_id=view_admin.id) PortfolioRoles.disable(portfolio_role=view_admin_pr) with pytest.raises(UnauthorizedError): user_can_access(