From 95f9e5a925980e3d6a9ef072a5746768dca26ed7 Mon Sep 17 00:00:00 2001 From: "Jay Newlin (PW)" Date: Mon, 17 Dec 2018 17:38:27 -0500 Subject: [PATCH 1/5] Ignore false partial branch --- atst/domain/auth.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atst/domain/auth.py b/atst/domain/auth.py index 10db8273..c4be2eea 100644 --- a/atst/domain/auth.py +++ b/atst/domain/auth.py @@ -51,7 +51,7 @@ def get_current_user(): def logout(): - if session.get("user_id"): + if session.get("user_id"): # pragma: no branch del (session["user_id"]) From 2e2eff2e8eb186b00283ee1f38fa799926921d63 Mon Sep 17 00:00:00 2001 From: "Jay Newlin (PW)" Date: Tue, 18 Dec 2018 10:46:51 -0500 Subject: [PATCH 2/5] Remove intentional partial branch from coverage stats --- atst/models/invitation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atst/models/invitation.py b/atst/models/invitation.py index 0b7d6686..18a5eff1 100644 --- a/atst/models/invitation.py +++ b/atst/models/invitation.py @@ -81,7 +81,7 @@ class Invitation(Base, TimestampsMixin, AuditableMixin): @property def workspace(self): - if self.workspace_role: + if self.workspace_role: #pragma: no branch return self.workspace_role.workspace @property From 4d834e65c7f045ed3c9832af124da531f5e697f7 Mon Sep 17 00:00:00 2001 From: "Jay Newlin (PW)" Date: Tue, 18 Dec 2018 11:14:19 -0500 Subject: [PATCH 3/5] All conditions are met by this point; no branch really exists --- atst/domain/invitations.py | 2 +- atst/models/invitation.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/atst/domain/invitations.py b/atst/domain/invitations.py index 5f69e039..f4edd757 100644 --- a/atst/domain/invitations.py +++ b/atst/domain/invitations.py @@ -84,7 +84,7 @@ class Invitations(object): elif invite.is_accepted or invite.is_revoked or invite.is_rejected: raise InvitationError(invite) - elif invite.is_pending: + elif invite.is_pending: # pragma: no branch Invitations._update_status(invite, InvitationStatus.ACCEPTED) WorkspaceRoles.enable(invite.workspace_role) return invite diff --git a/atst/models/invitation.py b/atst/models/invitation.py index 18a5eff1..1070ea4c 100644 --- a/atst/models/invitation.py +++ b/atst/models/invitation.py @@ -81,7 +81,7 @@ class Invitation(Base, TimestampsMixin, AuditableMixin): @property def workspace(self): - if self.workspace_role: #pragma: no branch + if self.workspace_role: # pragma: no branch return self.workspace_role.workspace @property From 628c61024b73a6596b0bc288f6b693ae2bb60313 Mon Sep 17 00:00:00 2001 From: "Jay Newlin (PW)" Date: Tue, 18 Dec 2018 11:32:00 -0500 Subject: [PATCH 4/5] Remove intentional partial branch from coverage stats --- atst/models/request.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atst/models/request.py b/atst/models/request.py index b66760fb..831f86a2 100644 --- a/atst/models/request.py +++ b/atst/models/request.py @@ -200,7 +200,7 @@ class Request(Base, mixins.TimestampsMixin, mixins.AuditableMixin): or self.status == RequestStatus.CHANGES_REQUESTED_TO_FINVER ): review = self.latest_status.review - if review: + if review: #pragma: no branch return review.comment @property From 0800e506e4a776d749a82a25e33d67fe97795d6e Mon Sep 17 00:00:00 2001 From: "Jay Newlin (PW)" Date: Tue, 18 Dec 2018 11:32:21 -0500 Subject: [PATCH 5/5] Format changed file --- atst/models/request.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atst/models/request.py b/atst/models/request.py index 831f86a2..ae065647 100644 --- a/atst/models/request.py +++ b/atst/models/request.py @@ -200,7 +200,7 @@ class Request(Base, mixins.TimestampsMixin, mixins.AuditableMixin): or self.status == RequestStatus.CHANGES_REQUESTED_TO_FINVER ): review = self.latest_status.review - if review: #pragma: no branch + if review: # pragma: no branch return review.comment @property