From 92d93c5553b85dc0b7ecc3e26c6ab0b49a0a3f30 Mon Sep 17 00:00:00 2001 From: George Drummond Date: Fri, 1 Feb 2019 09:50:45 -0500 Subject: [PATCH] Return incomplete not None for review section status --- atst/domain/task_orders.py | 4 ++-- tests/routes/task_orders/test_new_task_order.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/atst/domain/task_orders.py b/atst/domain/task_orders.py index fced1a3b..6ddf4ba2 100644 --- a/atst/domain/task_orders.py +++ b/atst/domain/task_orders.py @@ -109,8 +109,8 @@ class TaskOrders(object): return "complete" elif passed and failed: return "draft" - else: - return "incomplete" + + return "incomplete" @classmethod def all_sections_complete(cls, task_order): diff --git a/tests/routes/task_orders/test_new_task_order.py b/tests/routes/task_orders/test_new_task_order.py index 42211a78..bbe461e9 100644 --- a/tests/routes/task_orders/test_new_task_order.py +++ b/tests/routes/task_orders/test_new_task_order.py @@ -172,7 +172,7 @@ def test_show_task_order_display_screen(task_order): for i in range(2): assert screens[i]["completion"] == "complete" # the review section is not - assert not screens[3]["completion"] + assert screens[3]["completion"] == "incomplete" def test_update_task_order_with_no_task_order():