diff --git a/atst/domain/environments.py b/atst/domain/environments.py index 9ba60f53..e4e9e5b6 100644 --- a/atst/domain/environments.py +++ b/atst/domain/environments.py @@ -27,7 +27,7 @@ class Environments(object): db.session.commit() @classmethod - def add_member(cls, user, environment, member, role=None): + def add_member(cls, environment, member, role): environment_user = EnvironmentRole( user=member, environment=environment, role=role ) diff --git a/atst/domain/projects.py b/atst/domain/projects.py index cac6d4fa..36c1168d 100644 --- a/atst/domain/projects.py +++ b/atst/domain/projects.py @@ -14,9 +14,6 @@ class Projects(object): project = Project(workspace=workspace, name=name, description=description) Environments.create_many(project, environment_names) - for environment in project.environments: - Environments.add_member(user, environment, user) - db.session.add(project) db.session.commit() diff --git a/atst/routes/workspaces.py b/atst/routes/workspaces.py index effaf9e7..2a51f499 100644 --- a/atst/routes/workspaces.py +++ b/atst/routes/workspaces.py @@ -249,7 +249,8 @@ def update_member(workspace_id, member_id): if re.match("env_", entry): env_id = entry[4:] env_role = form_dict[entry] - ids_and_roles.append({"id": env_id, "role": env_role}) + if env_role: + ids_and_roles.append({"id": env_id, "role": env_role}) form = EditMemberForm(http_request.form) diff --git a/templates/workspaces/members/edit.html b/templates/workspaces/members/edit.html index 820d8a8e..79ba5e06 100644 --- a/templates/workspaces/members/edit.html +++ b/templates/workspaces/members/edit.html @@ -74,8 +74,6 @@