pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1013 from dod-ccpo/fix-cancel-button

Browse Source 
Update TO form cancel button behavior
This commit is contained in:
richard-dds
2019-08-09 09:50:38 -04:00
committed by GitHub
parent a941cca5e6 3b9a737675
commit 8fce880ae6
6 changed files with 57 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/routes/task_orders/test_new.py
View File

@@ -334,22 +334,20 @@ def test_cancel_can_create_new_to(client, user_session, portfolio):
assert response.status_code == 302
def test_cancel_edit_does_not_save_invalid_form_input(client, user_session, session):
def test_cancel_edit_causes_to_to_be_deleted(client, user_session, session):
task_order = TaskOrderFactory.create()
user_session(task_order.portfolio.owner)
bad_data = {"clins-0-jedi_clin_type": "foo"}
response = client.post(
url_for("task_orders.cancel_edit", task_order_id=task_order.id, save=True),
data=bad_data,
url_for("task_orders.cancel_edit", task_order_id=task_order.id, save=False),
data={},
)
assert response.status_code == 302
# CLINs should be unchanged
updated_task_order = session.query(TaskOrder).get(task_order.id)
assert updated_task_order.clins == task_order.clins
# TO should be deleted
assert session.query(TaskOrder).get(task_order.id) is None
def test_cancel_edit_on_invalid_input_does_not_flash(
def test_cancel_edit_and_save_with_invalid_input_does_not_flash(
app, client, user_session, session
):
task_order = TaskOrderFactory.create()
@@ -365,20 +363,6 @@ def test_cancel_edit_on_invalid_input_does_not_flash(
assert len(get_flashed_messages()) == 0
def test_cancel_edit_without_saving(client, user_session, session):
task_order = TaskOrderFactory.create(number=None)
user_session(task_order.portfolio.owner)
response = client.post(
url_for("task_orders.cancel_edit", task_order_id=task_order.id),
data={"number": "7643906432984"},
)
assert response.status_code == 302
# TO number should be unchanged
updated_task_order = session.query(TaskOrder).get(task_order.id)
assert updated_task_order.number is None
@pytest.mark.skip(reason="Reevaluate how form handles invalid data")
def test_task_orders_update_invalid_data(client, user_session, portfolio):
user_session(portfolio.owner)