clean up request review menu logic

atst/routes/requests/requests_form.py

@@ -138,7 +138,7 @@ def view_request_details(request_id=None):
         data["task_order"] = request.task_order.to_dictionary()
 
     return render_template(
-        "requests/view_pending.html",
+        "requests/details.html",
         data=data,
         request_id=request.id,
         status=request.status_displayname,

templates/requests/details.html

@@ -6,9 +6,7 @@
 <div class="col">
 
   {% if financial_verification %}
-    {% with complete=False %}
-      {% include 'requests/review_menu.html' %}
-    {% endwith %}
+    {% include 'requests/review_menu.html' %}
   {% endif %}
 
   {% if pending_review %}

templates/requests/financial_verification.html

@@ -6,9 +6,7 @@
 
 {% block content %}
 
-{% with complete=False %}
-  {% include 'requests/review_menu.html' %}
-{% endwith %}
+{% include 'requests/review_menu.html' %}
 
 <financial inline-template v-bind:initial-data='{{ f.data|mixedContentToJson }}'>
 <div class="col">

templates/requests/review_menu.html

@@ -7,9 +7,7 @@
         Request Information
       </a>
     </li>
-    {% if complete %}
-      {% set financial_status="complete" %}
-    {% elif g.matchesPath(financial_url) %}
+    {% if g.matchesPath(financial_url) %}
       {% set financial_status="active" %}
     {% else %}
       {% set financial_status="incomplete" %}