pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check proper permission for Workspaces.revoke_access

Browse Source
This commit is contained in:
richard-dds 2018-11-20 14:49:00 -05:00
parent fa8c59b944
commit 8dcde9da84
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
atst/domain/workspaces/workspaces.py
View File

@ -142,11 +142,10 @@ class Workspaces(object):
@classmethod @classmethod
def revoke_access(cls, user, workspace_id, workspace_role_id): def revoke_access(cls, user, workspace_id, workspace_role_id):
# TODO: What permission to here? Do we need a new one?
# Authorization.check_workspace_permission(
# user, workspace, Permissions.REQUEST_NEW_CSP_ROLE, "revoke workspace access"
# )
workspace = WorkspacesQuery.get(workspace_id) workspace = WorkspacesQuery.get(workspace_id)
Authorization.check_workspace_permission(
user, workspace, Permissions.ASSIGN_AND_UNASSIGN_ATAT_ROLE, "revoke workspace access"
)
workspace_role = WorkspaceRoles.get_by_id(workspace_role_id) workspace_role = WorkspaceRoles.get_by_id(workspace_role_id)
workspace_role.status = WorkspaceRoleStatus.DISABLED workspace_role.status = WorkspaceRoleStatus.DISABLED
for environment in workspace.all_environments: for environment in workspace.all_environments: