From 8cc9a2177034a9feca83ee305527541a5a99385b Mon Sep 17 00:00:00 2001 From: Montana Date: Wed, 21 Nov 2018 13:02:25 -0500 Subject: [PATCH] Fix audit event query --- tests/models/test_workspace_role.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/models/test_workspace_role.py b/tests/models/test_workspace_role.py index 3be8f7c3..796814db 100644 --- a/tests/models/test_workspace_role.py +++ b/tests/models/test_workspace_role.py @@ -38,6 +38,8 @@ def test_has_role_history(session): workspace = Workspaces.create(RequestFactory.create(creator=owner)) role = session.query(Role).filter(Role.name == 'developer').one() + # in order to get the history, we don't want the WorkspaceRoleFactory + # to commit after create() WorkspaceRoleFactory._meta.sqlalchemy_session_persistence = 'flush' workspace_role = WorkspaceRoleFactory.create(workspace=workspace, user=user, role=role) WorkspaceRoles.update_role(workspace_role, "admin") @@ -45,7 +47,7 @@ def test_has_role_history(session): session.query(AuditEvent) .filter( AuditEvent.resource_id == workspace_role.id, - AuditEvent.changed_state != None, + AuditEvent.action == 'update', ) .all() ) @@ -60,7 +62,8 @@ def test_has_status_history(session): user = UserFactory.create() workspace = Workspaces.create(RequestFactory.create(creator=owner)) - # in order to get the history, we don't want the WorkspaceRoleFactory to commit + # in order to get the history, we don't want the WorkspaceRoleFactory + # to commit after create() WorkspaceRoleFactory._meta.sqlalchemy_session_persistence = 'flush' workspace_role = WorkspaceRoleFactory.create(workspace=workspace, user=user) WorkspaceRoles.enable(workspace_role)