Fix secrets baseline and type hint error.

- detect-secrets was previously bumped to 0.13 but the baseline file was
  not updated.
- mypy objects to the way the Azure Subscription type was defined. Since
  the module is encapsulated for dependency injection, we can either
  declare it as a generic or remove the type hint. I did the latter,
  since I don't know that we gain anything by the former.
This commit is contained in:
dandds
2019-11-01 15:06:30 -04:00
parent 52de1471e0
commit 87a2da68dc
2 changed files with 4 additions and 5 deletions

View File

@@ -472,9 +472,7 @@ class AzureCloudProvider(CloudProviderInterface):
credentials = self._get_credential_obj(root_creds)
sub_client = self.sdk.subscription.SubscriptionClient(credentials)
subscription: self.sdk.subscription.models.Subscription = sub_client.subscriptions.get(
csp_environment_id
)
subscription = sub_client.subscriptions.get(csp_environment_id)
managment_principal = self._get_management_service_principal()