Handle setting no access for user environment roles:

- use constant for no access string
- update no access constant
- update language and permissions for rendering remove app member button
This commit is contained in:
dandds
2019-05-15 09:27:07 -04:00
parent 0dc0397702
commit 815632ed00
13 changed files with 47 additions and 33 deletions

View File

@@ -4,6 +4,7 @@ from flask import url_for
from atst.domain.permission_sets import PermissionSets
from atst.models import CSPRole
from atst.forms.data import ENV_ROLE_NO_ACCESS as NO_ACCESS
from tests.factories import *
@@ -120,8 +121,7 @@ def test_update_team_environment_roles(client, user_session):
assert env_role.role == CSPRole.TECHNICAL_READ.value
@pytest.mark.skip(reason="Need to rebase against master")
def test_update_team_revoke_environment_access(client, user_session):
def test_update_team_revoke_environment_access(client, user_session, db, session):
application = ApplicationFactory.create()
owner = application.portfolio.owner
app_role = ApplicationRoleFactory.create(
@@ -141,12 +141,13 @@ def test_update_team_revoke_environment_access(client, user_session):
"members-0-permission_sets-perms_env_mgmt": PermissionSets.EDIT_APPLICATION_ENVIRONMENTS,
"members-0-permission_sets-perms_del_env": PermissionSets.DELETE_APPLICATION_ENVIRONMENTS,
"members-0-environment_roles-0-environment_id": environment.id,
"members-0-environment_roles-0-role": "",
"members-0-environment_roles-0-role": NO_ACCESS,
},
)
assert response.status_code == 302
assert env_role.role == CSPRole.TECHNICAL_READ.value
env_role_exists = db.exists().where(EnvironmentRole.id == env_role.id)
assert not session.query(env_role_exists).scalar()
def test_create_member(client, user_session):