Update schema and create/update Environments domain methods to enforce environment name uniqueness within an application context.

atst/domain/environments.py

@@ -12,6 +12,7 @@ from atst.models import (
     CLIN,
 )
 from atst.domain.environment_roles import EnvironmentRoles
+from atst.utils import update_or_raise_already_exists_error
 
 from .exceptions import NotFoundError, DisabledError
 
@@ -21,7 +22,7 @@ class Environments(object):
     def create(cls, user, application, name):
         environment = Environment(application=application, name=name, creator=user)
         db.session.add(environment)
-        db.session.commit()
+        update_or_raise_already_exists_error(message="environment")
         return environment
 
     @classmethod
@@ -39,7 +40,8 @@ class Environments(object):
         if name is not None:
             environment.name = name
             db.session.add(environment)
-            db.session.commit()
+            update_or_raise_already_exists_error(message="environment")
+            return environment
 
     @classmethod
     def get(cls, environment_id):

atst/models/environment.py

@@ -1,4 +1,4 @@
-from sqlalchemy import Column, ForeignKey, String, TIMESTAMP
+from sqlalchemy import Column, ForeignKey, String, TIMESTAMP, UniqueConstraint
 from sqlalchemy.orm import relationship
 from sqlalchemy.dialects.postgresql import JSONB
 from enum import Enum
@@ -38,6 +38,12 @@ class Environment(
         primaryjoin="and_(EnvironmentRole.environment_id == Environment.id, EnvironmentRole.deleted == False)",
     )
 
+    __table_args__ = (
+        UniqueConstraint(
+            "name", "application_id", name="environments_name_application_id_key"
+        ),
+    )
+
     class ProvisioningStatus(Enum):
         PENDING = "pending"
         COMPLETED = "completed"