From 79cb7ac2eb8123437241d1481f987755f4a8045a Mon Sep 17 00:00:00 2001 From: dandds Date: Thu, 14 Mar 2019 14:24:41 -0400 Subject: [PATCH] use first_or_none utility for finding portfolio role --- atst/domain/authz.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/atst/domain/authz.py b/atst/domain/authz.py index 6fb27924..eae7cf3f 100644 --- a/atst/domain/authz.py +++ b/atst/domain/authz.py @@ -1,3 +1,4 @@ +from atst.utils import first_or_none from atst.models.permissions import Permissions from atst.domain.exceptions import UnauthorizedError @@ -5,8 +6,8 @@ from atst.domain.exceptions import UnauthorizedError class Authorization(object): @classmethod def has_portfolio_permission(cls, user, portfolio, permission): - port_role = next( - (pr for pr in user.portfolio_roles if pr.portfolio == portfolio), None + port_role = first_or_none( + lambda pr: pr.portfolio == portfolio, user.portfolio_roles ) if port_role: return permission in port_role.permissions