pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DRY out _get_form

Browse Source
This commit is contained in:
richard-dds 2018-10-15 17:08:39 -04:00
parent 54192c6c5d
commit 789e5c0906
1 changed files with 29 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

95
atst/routes/requests/financial_verification.py
View File

@ -12,38 +12,41 @@ from atst.domain.requests.financial_verification import (
) )
class GetFinancialVerificationForm(object): class FinancialVerificationBase(object):
def _get_form(self, request, is_extended, input_data):
data = input_data
fv_data = request.body.get("financial_verification", {})
data = {**data, **fv_data}
if request.task_order:
task_order_dict = request.task_order.to_dictionary()
task_order_dict.update({
"task_order_number": request.task_order.number,
"funding_type": request.task_order.funding_type.value
})
data = {**data, **task_order_dict}
mdict = ImmutableMultiDict(data)
if is_extended:
return ExtendedFinancialForm(formdata=mdict)
else:
return FinancialForm(formdata=mdict)
class GetFinancialVerificationForm(FinancialVerificationBase):
def __init__(self, user, request, is_extended=False): def __init__(self, user, request, is_extended=False):
self.user = user self.user = user
self.request = request self.request = request
self.is_extended = is_extended self.is_extended = is_extended
def _get_form(self):
data = {}
fv_data = self.request.body.get("financial_verification")
if fv_data:
data = {**data, **fv_data}
if self.request.task_order:
task_order_dict = self.request.task_order.to_dictionary()
task_order_dict.update({
"task_order_number": self.request.task_order.number,
"funding_type": self.request.task_order.funding_type.value
})
data = {**data, **task_order_dict}
if self.is_extended:
return ExtendedFinancialForm(data=data)
else:
return FinancialForm(data=data)
def execute(self): def execute(self):
form = self._get_form() form = self._get_form(self.request, self.is_extended, {})
return {"form": form} return {"form": form}
class UpdateFinancialVerification(object): class UpdateFinancialVerification(FinancialVerificationBase):
def __init__( def __init__(
self, self,
pe_validator, pe_validator,
@ -60,28 +63,8 @@ class UpdateFinancialVerification(object):
self.fv_data = fv_data self.fv_data = fv_data
self.is_extended = is_extended self.is_extended = is_extended
def _get_form(self):
data = self.fv_data
existing_fv_data = self.request.body.get("financial_verification", {})
data = {**data, **existing_fv_data}
if self.request.task_order:
task_order_dict = self.request.task_order.to_dictionary()
task_order_dict.update({
"task_order_number": self.request.task_order.number,
"funding_type": self.request.task_order.funding_type.value
})
data = {**data, **task_order_dict}
mdict = ImmutableMultiDict(data)
if self.is_extended:
return ExtendedFinancialForm(formdata=mdict)
else:
return FinancialForm(formdata=mdict)
def execute(self): def execute(self):
form = self._get_form() form = self._get_form(self.request, self.is_extended, self.fv_data)
should_update = True should_update = True
should_submit = True should_submit = True
@ -133,7 +116,7 @@ class UpdateFinancialVerification(object):
return {"state": "pending", "request": updated_request} return {"state": "pending", "request": updated_request}
class SaveFinancialVerificationDraft(object): class SaveFinancialVerificationDraft(FinancialVerificationBase):
def __init__( def __init__(
self, self,
pe_validator, pe_validator,
@ -150,28 +133,8 @@ class SaveFinancialVerificationDraft(object):
self.fv_data = fv_data self.fv_data = fv_data
self.is_extended = is_extended self.is_extended = is_extended
def _get_form(self):
data = self.fv_data
existing_fv_data = self.request.body.get("financial_verification", {})
data = {**data, **existing_fv_data}
if self.request.task_order:
task_order_dict = self.request.task_order.to_dictionary()
task_order_dict.update({
"task_order_number": self.request.task_order.number,
"funding_type": self.request.task_order.funding_type.value
})
data = {**data, **task_order_dict}
mdict = ImmutableMultiDict(data)
if self.is_extended:
return ExtendedFinancialForm(formdata=mdict)
else:
return FinancialForm(formdata=mdict)
def execute(self): def execute(self):
form = self._get_form() form = self._get_form(self.request, self.is_extended, self.fv_data)
valid = True valid = True
if not form.validate_draft(): if not form.validate_draft():