Use solid/filled Font Awesome icons for consistency.

Some of the "open" icons are not in the free FA tier, so rather than mix
the two we should use solid icons everywhere.

templates/fragments/admin/add_new_portfolio_member.html

@@ -81,5 +81,5 @@
     url_for("portfolios.create_member", portfolio_id=portfolio.id),
     [step_one, step_two],
     button_text=("portfolios.admin.add_new_member" | translate),
-    button_icon="plus-circle-solid",
+    button_icon="plus",
   ) }}

templates/fragments/applications/add_new_application_member.html

@@ -132,5 +132,5 @@
     url_for("applications.create_member", application_id=application.id),
     [step_one, step_two],
     button_text=("portfolios.admin.add_new_member" | translate),
-    button_icon="plus-circle-solid",
+    button_icon="plus",
   ) }}

templates/navigation/global_sidenav.html

@@ -32,7 +32,7 @@
         <div class="sidenav__divider--small"></div>
         <a class="sidenav__link sidenav__link--add" href="{{ url_for("task_orders.get_started") }}" title="Fund a New Portfolio">
           <span class="sidenav__link-label">Fund a new portfolio</span>
-          {{ Icon("plus", classes="sidenav__link-icon icon--circle") }}
+          {{ Icon("plus", classes="sidenav__link-icon") }}
         </a>
       </div>
     </div>

templates/portfolios/applications/index.html

@@ -15,7 +15,7 @@
       {% if can_create_applications %}
         <a class='icon-link' href='{{ url_for('applications.new', portfolio_id=portfolio.id) }}'>
           {{ 'portfolios.applications.add_application_text' | translate }}
-          {{ Icon("plus", classes="sidenav__link-icon icon--circle") }}
+          {{ Icon("plus", classes="sidenav__link-icon") }}
         </a>
       {% endif %}
     </div>

templates/portfolios/applications/members.html

@@ -65,7 +65,7 @@
           <td class="add-member-link" colspan=4>
             <a class="icon-link" href="{{ url_for('portfolios.new_member', portfolio_id=portfolio.id) }}">
               Add A New Member
-              {{ Icon('plus', classes='icon--circle') }}
+              {{ Icon('plus') }}
             </a>
           </td>
         </tr>

templates/portfolios/applications/settings.html

@@ -72,7 +72,7 @@
             <button class="usa-button usa-button-primary" tabindex="0" type="submit">{{ 'portfolios.applications.update_button_text' | translate }}</button>
             <a class='icon-link'>
               {{ "portfolios.applications.add_environment" | translate }}
-              {{ Icon('plus-circle-solid') }}
+              {{ Icon('plus') }}
             </a>
           </div>
         </div>