From 6dc5c1496474a3437b9187701e0f72dca49afa28 Mon Sep 17 00:00:00 2001
From: leigh-mil <leigh-ctr@friends.dds.mil>
Date: Thu, 1 Aug 2019 10:37:24 -0400
Subject: [PATCH] Use correct perms to show edit env form and remove
 unnecessary perms check to show links for app settings and team

---
 templates/portfolios/applications/index.html   | 18 +++++++-----------
 .../portfolios/applications/settings.html      |  2 +-
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/templates/portfolios/applications/index.html b/templates/portfolios/applications/index.html
index 369e03eb..ea23ecec 100644
--- a/templates/portfolios/applications/index.html
+++ b/templates/portfolios/applications/index.html
@@ -45,20 +45,16 @@
                 <h3 class='icon-link accordion__title' v-on:click="toggleSection('{{ section_name }}')">{{ application.name }}</h3>
                 <span class='accordion__description'>{{ application.description }}</span>
                 <div class='accordion__actions'>
-                  {% if user_can(permissions.VIEW_APPLICATION) %}
-                    <a class='icon-link' href='{{ url_for("applications.settings", application_id=application.id) }}'>
-                      <span>{{ "portfolios.applications.app_settings_text" | translate }}</span>
-                    </a>
-                    <div class='separator'></div>
-                  {% endif %}
-                  {% if user_can(permissions.VIEW_PORTFOLIO_USERS) %}
+                  <a class='icon-link' href='{{ url_for("applications.settings", application_id=application.id) }}'>
+                    <span>{{ "portfolios.applications.app_settings_text" | translate }}</span>
+                  </a>
+                  <div class='separator'></div>
                   <a
                     href="{{ url_for('applications.team', application_id=application.id) }}"
                     class='icon-link'>
-                      <span>{{ "portfolios.applications.team_text" | translate }} ({{ application.members | length }})</span>
-                    </a>
-                    <div class='separator'></div>
-                  {% endif %}
+                    <span>{{ "portfolios.applications.team_text" | translate }} ({{ application.members | length }})</span>
+                  </a>
+                  <div class='separator'></div>
                   <a class='icon-link triangle-box' v-on:click="toggleSection('{{ section_name }}')">
                     <span>Environments ({{ application.environments|length }})</span>
                     <span v-if="selectedSection === '{{ section_name }}'">
diff --git a/templates/portfolios/applications/settings.html b/templates/portfolios/applications/settings.html
index 711eff33..b9bea61f 100644
--- a/templates/portfolios/applications/settings.html
+++ b/templates/portfolios/applications/settings.html
@@ -80,7 +80,7 @@
         {% include "fragments/flash.html" %}
       {% endif %}
 
-      {% if user_can(permissions.EDIT_APPLICATION) %}
+      {% if user_can(permissions.EDIT_ENVIRONMENT) %}
         {% include "fragments/applications/edit_environments.html" %}
 
         {% if user_can(permissions.CREATE_ENVIRONMENT) %}