Clean up html and move text into translations

templates/portfolios/applications/settings.html

@@ -104,8 +104,8 @@
       {% set new_member_modal_name = "add-app-mem" %}
       {% if user_can(permissions.CREATE_APPLICATION_MEMBER) %}
         <a class="icon-link modal-link" v-on:click="openModal('{{ new_member_modal_name }}')">
-          {{ "portfolios.admin.add_new_member" | translate }}
           {{ Icon("plus") }}
+          {{ "portfolios.applications.add_member" | translate }}
         </a>
       {% endif %}
     </div>
@@ -158,21 +158,18 @@
     </section>
   {% endif %}
 
-
   <div class='subheading'>
-    Environments
+    {{ 'common.resource_names.environments' | translate }}
 
     {% if user_can(permissions.CREATE_ENVIRONMENT) %}
       {% include "fragments/applications/add_new_environment.html" %}
     {% endif %}
   </div>
 
-
-  {% if g.matchesPath("application-environments") %}
-    {% include "fragments/flash.html" %}
-  {% endif %}
-
   <div class="panel">
+    {% if g.matchesPath("application-environments") %}
+      {% include "fragments/flash.html" %}
+    {% endif %}
     <div class="panel__content">
       <div class="accordion-table accordion-table-list">
         <ul class="accordion-table__items">
@@ -200,28 +197,20 @@
                         }}
                       </span>
                       <span class="accordion-table__item__toggler icon-link">
-                        {% set open_members_button %}
-                          {{ env['member_count'] }} members
-                        {% endset %}
-
-                        {% set close_members_button %}
-                          {{ env['member_count'] }} members
-                        {% endset %}
-
+                        {% set members_button = "portfolios.applications.member_count" | translate({'count': env['member_count']}) %}
                         {{
                           ToggleButton(
-                            open_html=open_members_button,
-                            close_html=close_members_button,
+                            open_html=members_button,
+                            close_html=members_button,
                             section_name="members"
                           )
                         }}
                       </span>
                     </div>
-
                   </div>
                   <div class="form-col form-col--third">
                     <a href='{{ url_for("applications.access_environment", environment_id=env.id)}}' target='_blank' rel='noopener noreferrer' class='application-list-item__environment__csp_link icon-link'>
-                      <span>Cloud Service Provider Link {{ Icon('link', classes="icon--tiny") }}</span>
+                      <span>{{ "portfolios.applications.csp_link" | translate }} {{ Icon('link', classes="icon--tiny") }}</span>
                     </a>
                   </div>
                 </div>