diff --git a/atst/models/application_role.py b/atst/models/application_role.py index 12c7a9c3..f8f7f201 100644 --- a/atst/models/application_role.py +++ b/atst/models/application_role.py @@ -113,19 +113,17 @@ class ApplicationRole( @property def display_status(self): if ( - self.is_pending - and self.latest_invitation - and self.latest_invitation.is_pending - ): - return "invite_pending" - - elif ( self.is_pending and self.latest_invitation and self.latest_invitation.is_expired ): return "invite_expired" - + elif ( + self.is_pending + and self.latest_invitation + and self.latest_invitation.is_pending + ): + return "invite_pending" elif self.is_active and any( env_role.is_pending for env_role in self.environment_roles ): diff --git a/js/components/multi_checkbox_input.js b/js/components/multi_checkbox_input.js index 8ef4e880..fdba839f 100644 --- a/js/components/multi_checkbox_input.js +++ b/js/components/multi_checkbox_input.js @@ -14,6 +14,7 @@ export default { default: () => [], }, initialOtherValue: String, + optional: Boolean, }, data: function() { @@ -45,7 +46,7 @@ export default { computed: { valid: function() { - return this.showValid + return this.optional || this.showValid }, }, } diff --git a/js/components/options_input.js b/js/components/options_input.js index 639c8454..fafd0e02 100644 --- a/js/components/options_input.js +++ b/js/components/options_input.js @@ -10,10 +10,6 @@ export default { default: () => [], }, initialValue: String, - watch: { - type: Boolean, - default: false, - }, optional: Boolean, nullOption: { type: String, diff --git a/js/mixins/text_input_mixin.js b/js/mixins/text_input_mixin.js index 54f8a7cf..87471a50 100644 --- a/js/mixins/text_input_mixin.js +++ b/js/mixins/text_input_mixin.js @@ -27,10 +27,6 @@ export default { paragraph: String, noMaxWidth: String, optional: Boolean, - watch: { - type: Boolean, - default: false, - }, }, data: function() { diff --git a/templates/applications/fragments/member_form_fields.html b/templates/applications/fragments/member_form_fields.html index 97ab3832..20ecc210 100644 --- a/templates/applications/fragments/member_form_fields.html +++ b/templates/applications/fragments/member_form_fields.html @@ -66,8 +66,7 @@ + v-bind:optional="true">
{{ sub_form.role(**{"v-model": "value", "id": "{}-{}".format(sub_form.role.name, member_role_id)}) }}
diff --git a/templates/components/clin_dollar_amount.html b/templates/components/clin_dollar_amount.html index dd8468dc..c39d3ef6 100644 --- a/templates/components/clin_dollar_amount.html +++ b/templates/components/clin_dollar_amount.html @@ -1,6 +1,6 @@ {% from 'components/icon.html' import Icon %} -{% macro CLINDollarAmount(type, field=None, funding_validation=False) -%} +{% macro CLINDollarAmount(type, field=None, funding_validation=False) -%}
+ validation="clinDollars">
{% if field %} -
- {%- endmacro %} \ No newline at end of file + {%- endmacro %} diff --git a/templates/components/clin_fields.html b/templates/components/clin_fields.html index 94ca2a5b..6d79dc08 100644 --- a/templates/components/clin_fields.html +++ b/templates/components/clin_fields.html @@ -41,10 +41,9 @@
{% if fields %} - {{ TextInput(fields.number, watch=True, optional=False) }} + {{ TextInput(fields.number, optional=False) }} {% else %} - +