From 6a39ce2a525fbe31a8764c6d1ece1eab48428c35 Mon Sep 17 00:00:00 2001 From: richard-dds Date: Mon, 5 Nov 2018 11:44:59 -0500 Subject: [PATCH] Allow drafts to be saved without pe_number --- atst/routes/requests/financial_verification.py | 2 +- tests/routes/test_financial_verification.py | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/atst/routes/requests/financial_verification.py b/atst/routes/requests/financial_verification.py index ff9617f7..0e37f068 100644 --- a/atst/routes/requests/financial_verification.py +++ b/atst/routes/requests/financial_verification.py @@ -173,7 +173,7 @@ class SaveFinancialVerificationDraft(FinancialVerificationBase): if not form.validate_draft(): self._raise(form) - if not self.pe_validator.validate(self.request, form.pe_id): + if form.pe_id.data and not self.pe_validator.validate(self.request, form.pe_id): valid = False if form.task_order.number.data and not self.task_order_validator.validate( diff --git a/tests/routes/test_financial_verification.py b/tests/routes/test_financial_verification.py index 24e02ac5..3c0241dc 100644 --- a/tests/routes/test_financial_verification.py +++ b/tests/routes/test_financial_verification.py @@ -111,6 +111,20 @@ def test_update_fv_invalid_task_order_number(fv_data): update_fv.execute() +def test_draft_without_pe_id(fv_data): + request = RequestFactory.create() + user = UserFactory.create() + data = {"request-uii_ids": "1234"} + assert SaveFinancialVerificationDraft( + PENumberValidator(), + TaskOrderNumberValidator(), + user, + request, + data, + is_extended=False, + ).execute() + + def test_update_fv_extended(fv_data, e_fv_data): request = RequestFactory.create() user = UserFactory.create()