New custom validator RequiredIf

tests/forms/test_validators.py

@@ -6,7 +6,7 @@ from atst.forms.validators import (
     IsNumber,
     PhoneNumber,
     ListItemsUnique,
-    RequiredIfNot,
+    RequiredIf,
 )
 
 
@@ -81,29 +81,56 @@ class TestListItemsUnique:
             validator(dummy_form, dummy_field)
 
 
-class TestRequiredIfNot:
-    def test_RequiredIfNot_requires_field_if_arg_is_falsy(
+class TestRequiredIf:
+    def test_RequiredIf_requires_field_if_arg_is_truthy(
         self, dummy_form_with_field, dummy_field
     ):
-        form = dummy_form_with_field("arg", False)
-        validator = RequiredIfNot("arg")
+        form = dummy_form_with_field("arg", True)
+        validator = RequiredIf("arg")
         dummy_field.data = None
 
         with pytest.raises(ValidationError):
             validator(form, dummy_field)
 
-    def test_RequiredIfNot_does_not_require_field_if_arg_is_truthy(
+    def test_RequiredIf_does_not_require_field_if_arg_is_falsy(
         self, dummy_form_with_field, dummy_field
     ):
-        form = dummy_form_with_field("arg", True)
-        validator = RequiredIfNot("arg")
+        form = dummy_form_with_field("arg", False)
+        validator = RequiredIf("arg")
         dummy_field.data = None
 
         with pytest.raises(StopValidation):
             validator(form, dummy_field)
 
-    def test_RequiredIfNot_arg_is_None_raises_error(self, dummy_form, dummy_field):
-        validator = RequiredIfNot("arg")
+    def test_RequiredIf_arg_is_None_raises_error(self, dummy_form, dummy_field):
+        validator = RequiredIf("arg")
+        dummy_field.data = "some data"
+
+        with pytest.raises(Exception):
+            validator(dummy_form, dummy_field)
+
+    def test_not_RequiredIf_requires_field_if_arg_is_falsy(
+        self, dummy_form_with_field, dummy_field
+    ):
+        form = dummy_form_with_field("arg", False)
+        validator = RequiredIf("arg", False)
+        dummy_field.data = None
+
+        with pytest.raises(ValidationError):
+            validator(form, dummy_field)
+
+    def test_not_RequiredIf_does_not_require_field_if_arg_is_truthy(
+        self, dummy_form_with_field, dummy_field
+    ):
+        form = dummy_form_with_field("arg", True)
+        validator = RequiredIf("arg", False)
+        dummy_field.data = None
+
+        with pytest.raises(StopValidation):
+            validator(form, dummy_field)
+
+    def test_not_RequiredIf_arg_is_None_raises_error(self, dummy_form, dummy_field):
+        validator = RequiredIf("arg", False)
         dummy_field.data = "some data"
 
         with pytest.raises(Exception):