create system request reviews when request is automatically accepted for financial verification
This commit is contained in:
@@ -62,13 +62,12 @@ class Requests(object):
|
||||
def submit(cls, request):
|
||||
request = Requests.set_status(request, RequestStatus.SUBMITTED)
|
||||
|
||||
new_status = None
|
||||
if Requests.should_auto_approve(request):
|
||||
new_status = RequestStatus.PENDING_FINANCIAL_VERIFICATION
|
||||
request = Requests.set_status(request, RequestStatus.PENDING_FINANCIAL_VERIFICATION)
|
||||
Requests._add_review(None, request, {"comment": "Auto-approval for dollar value below {}".format(Requests.AUTO_APPROVE_THRESHOLD)})
|
||||
else:
|
||||
new_status = RequestStatus.PENDING_CCPO_ACCEPTANCE
|
||||
request = Requests.set_status(request, RequestStatus.PENDING_CCPO_ACCEPTANCE)
|
||||
|
||||
request = Requests.set_status(request, new_status)
|
||||
request = RequestsQuery.add_and_commit(request)
|
||||
|
||||
return request
|
||||
|
@@ -10,7 +10,7 @@ class RequestReview(Base, mixins.TimestampsMixin, mixins.AuditableMixin):
|
||||
id = types.Id()
|
||||
status = relationship("RequestStatusEvent", uselist=False, back_populates="review")
|
||||
|
||||
user_id = Column(ForeignKey("users.id"), nullable=False)
|
||||
user_id = Column(ForeignKey("users.id"))
|
||||
reviewer = relationship("User")
|
||||
|
||||
comment = Column(String)
|
||||
@@ -23,7 +23,10 @@ class RequestReview(Base, mixins.TimestampsMixin, mixins.AuditableMixin):
|
||||
|
||||
@property
|
||||
def full_name_reviewer(self):
|
||||
return self.reviewer.full_name
|
||||
if self.reviewer:
|
||||
return self.reviewer.full_name
|
||||
else:
|
||||
return "System"
|
||||
|
||||
@property
|
||||
def full_name_mao(self):
|
||||
|
Reference in New Issue
Block a user