pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Applications users were invited to were not showing in the portfolios

Browse Source 
sidebar
This commit is contained in:
George Drummond
2019-05-20 15:18:26 -04:00
parent 42900a20a6
commit 6487fe91ba
7 changed files with 41 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/routes/portfolios/test_invitations.py
View File

@@ -34,7 +34,7 @@ def test_existing_member_accepts_valid_invite(client, user_session):
# user is redirected to the portfolio view
assert response.status_code == 302
assert (
url_for("portfolios.show_portfolio", portfolio_id=invite.portfolio.id)
url_for("applications.portfolio_applications", portfolio_id=invite.portfolio.id)
in response.headers["Location"]
)
# the one-time use invite is no longer usable
@@ -77,7 +77,7 @@ def test_new_member_accepts_valid_invite(monkeypatch, client, user_session):
# user is redirected to the portfolio view
assert response.status_code == 302
assert (
url_for("portfolios.show_portfolio", portfolio_id=portfolio.id)
url_for("applications.portfolio_applications", portfolio_id=portfolio.id)
in response.headers["Location"]
)
# the user has access to the portfolio

13
tests/test_access.py
View File

@@ -466,19 +466,6 @@ def test_portfolios_revoke_invitation_access(post_url_assert_status):
post_url_assert_status(user, url, status)
# portfolios.show_portfolio
def test_portfolios_show_portfolio_access(get_url_assert_status):
ccpo = user_with(PermissionSets.VIEW_PORTFOLIO)
owner = user_with()
rando = user_with()
portfolio = PortfolioFactory.create(owner=owner)
url = url_for("portfolios.show_portfolio", portfolio_id=portfolio.id)
get_url_assert_status(ccpo, url, 302)
get_url_assert_status(owner, url, 302)
get_url_assert_status(rando, url, 404)
# task_orders.so_review
def test_task_orders_so_review_access(get_url_assert_status):
ccpo = UserFactory.create_ccpo()