pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor application team routes

Browse Source 
- pulling out helper functions for constructing forms
- return 400 for form validation errors
- "Yes" appears green on the read only version
This commit is contained in:
Montana
2019-05-07 11:47:27 -04:00
parent d5307b440f
commit 644acc68fa
5 changed files with 61 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/forms/test_team.py
View File

@@ -9,7 +9,7 @@ def test_permissions_form_permission_sets():
form_data = {
"perms_team_mgmt": PermissionSets.EDIT_APPLICATION_TEAM,
"perms_env_mgmt": PermissionSets.VIEW_APPLICATION,
"perms_del_env": "View only",
"perms_del_env": PermissionSets.VIEW_APPLICATION,
}
form = PermissionsForm(data=form_data)
@@ -17,7 +17,7 @@ def test_permissions_form_permission_sets():
assert form.data == [
PermissionSets.EDIT_APPLICATION_TEAM,
PermissionSets.VIEW_APPLICATION,
"View only",
PermissionSets.VIEW_APPLICATION,
]
@@ -25,7 +25,7 @@ def test_permissions_form_invalid():
form_data = {
"perms_team_mgmt": PermissionSets.EDIT_APPLICATION_TEAM,
"perms_env_mgmt": "not a real choice",
"perms_del_env": "View only",
"perms_del_env": PermissionSets.VIEW_APPLICATION,
}
form = PermissionsForm(data=form_data)
assert not form.validate()