Merge pull request #517 from dod-ccpo/hide-requests

hide requests workflow

tests/routes/test_auth.py

@@ -4,20 +4,22 @@ from urllib.parse import quote
 from tests.factories import UserFactory
 
 
+PROTECTED_URL = "/workspaces"
+
+
 def test_request_page_with_complete_profile(client, user_session):
     user = UserFactory.create()
     user_session(user)
-    response = client.get("/requests", follow_redirects=False)
+    response = client.get(PROTECTED_URL, follow_redirects=False)
     assert response.status_code == 200
 
 
 def test_redirect_when_profile_missing_fields(client, user_session):
     user = UserFactory.create(date_latest_training=None)
     user_session(user)
-    requested_url = "/requests"
-    response = client.get(requested_url, follow_redirects=False)
+    response = client.get(PROTECTED_URL, follow_redirects=False)
     assert response.status_code == 302
-    assert "/user?next={}".format(quote(requested_url, safe="")) in response.location
+    assert "/user?next={}".format(quote(PROTECTED_URL, safe="")) in response.location
 
 
 def test_unprotected_route_with_incomplete_profile(client, user_session):
@@ -30,7 +32,7 @@ def test_unprotected_route_with_incomplete_profile(client, user_session):
 def test_completing_user_profile(client, user_session):
     user = UserFactory.create(phone_number=None)
     user_session(user)
-    response = client.get("/requests", follow_redirects=True)
+    response = client.get(PROTECTED_URL, follow_redirects=True)
     assert b"You must complete your profile" in response.data
 
     updated_data = {**user.to_dictionary(), "phone_number": "5558675309"}
@@ -40,6 +42,6 @@ def test_completing_user_profile(client, user_session):
     response = client.post(url_for("users.update_user"), data=updated_data)
     assert response.status_code == 200
 
-    response = client.get("/requests", follow_redirects=False)
+    response = client.get(PROTECTED_URL, follow_redirects=False)
     assert response.status_code == 200
     assert b"You must complete your profile" not in response.data

tests/routes/test_errors.py

@@ -1,4 +1,5 @@
 import pytest
+from flask import url_for
 
 
 @pytest.fixture
@@ -10,7 +11,7 @@ def csrf_enabled_app(app):
 
 def test_csrf_error(csrf_enabled_app, client):
     response = client.post(
-        "/requests/new/1",
+        url_for("users.user"),
         headers={"Content-Type": "application/x-www-form-urlencoded"},
         data="csrf_token=invalid_token",
         follow_redirects=True,

tests/routes/test_home.py

@@ -19,6 +19,7 @@ def test_user_without_workspaces_has_no_workspaces_nav(client, user_session):
     assert b'href="/workspaces"' not in response.data
 
 
+@pytest.mark.skip(reason="this may no longer be accurate")
 def test_request_owner_with_no_workspaces_redirected_to_requests(client, user_session):
     request = RequestFactory.create()
     user_session(request.creator)
@@ -50,6 +51,7 @@ def test_request_owner_with_more_than_one_workspace_redirected_to_workspaces(
     assert "/workspaces" in response.location
 
 
+@pytest.mark.skip(reason="this may no longer be accurate")
 def test_non_owner_user_with_no_workspaces_redirected_to_requests(client, user_session):
     user = UserFactory.create()
 
@@ -86,6 +88,7 @@ def test_non_owner_user_with_mulitple_workspaces_redirected_to_workspaces(
     assert "/workspaces" in response.location
 
 
+@pytest.mark.skip(reason="this may no longer be accurate")
 def test_ccpo_user_redirected_to_requests(client, user_session):
     user = UserFactory.from_atat_role("ccpo")
     for _ in range(3):