pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update form to handle No access

Browse Source
This commit is contained in:
leigh-mil
2019-04-23 15:39:31 -04:00
parent 9b426bbde4
commit 5e415edaef
5 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/domain/test_environments.py
View File

@@ -34,9 +34,7 @@ def test_update_env_role():
def test_update_env_role_no_access():
env_role = EnvironmentRoleFactory.create(role=CSPRole.BASIC_ACCESS.value)
assert Environments.update_env_role(
env_role.environment, env_role.user, "No access"
)
assert Environments.update_env_role(env_role.environment, env_role.user, None)
assert not EnvironmentRoles.get(env_role.user.id, env_role.environment.id)
@@ -84,7 +82,7 @@ def test_update_env_roles_by_environment():
{
"user_id": env_role_3.user.id,
"name": env_role_3.user.full_name,
"role": "No access",
"role": None,
},
]
@@ -119,7 +117,7 @@ def test_update_env_roles_by_member():
{"id": dev.id, "role": CSPRole.NETWORK_ADMIN.value},
{"id": staging.id, "role": CSPRole.BUSINESS_READ.value},
{"id": prod.id, "role": CSPRole.TECHNICAL_READ.value},
{"id": testing.id, "role": "No access"},
{"id": testing.id, "role": None},
]
Environments.update_env_roles_by_member(user, env_roles)

4
tests/routes/applications/test_settings.py
View File

@@ -189,7 +189,7 @@ def test_user_with_permission_can_update_team_env_roles(client, user_session):
"team_roles-1-role": CSPRole.BASIC_ACCESS.value,
"team_roles-2-user_id": env_role_3.user.id,
"team_roles-2-name": env_role_3.user.full_name,
"team_roles-2-role": "No access",
"team_roles-2-role": "",
"team_roles-3-user_id": app_role.user.id,
"team_roles-3-name": app_role.user.full_name,
"team_roles-3-role": CSPRole.TECHNICAL_READ.value,
@@ -227,7 +227,7 @@ def test_user_without_permission_cannot_update_team_env_roles(client, user_sessi
"team_roles-0-role": CSPRole.NETWORK_ADMIN.value,
"team_roles-1-user_id": env_role_2.user.id,
"team_roles-1-name": env_role_2.user.full_name,
"team_roles-1-role": "No access",
"team_roles-1-role": "",
"team_roles-2-user_id": app_role.user.id,
"team_roles-2-name": app_role.user.full_name,
"team_roles-2-role": CSPRole.TECHNICAL_READ.value,