Update form to handle No access

atst/domain/environments.py

@@ -66,7 +66,7 @@ class Environments(object):
     def update_env_role(cls, environment, user, new_role):
         updated = False
 
-        if new_role is None or new_role == "No access":
+        if new_role is None:
             role_deleted = EnvironmentRoles.delete(user.id, environment.id)
             if role_deleted:
                 updated = True

atst/forms/app_settings.py

@@ -9,6 +9,13 @@ class EnvMemberRoleForm(BaseForm):
     user_id = HiddenField()
     role = RadioField(choices=ENV_ROLES)
 
+    @property
+    def data(self):
+        _data = super().data
+        if _data["role"] == "":
+            _data["role"] = None
+        return _data
+
 
 class EnvironmentRolesForm(BaseForm):
     team_roles = FieldList(FormField(EnvMemberRoleForm))

atst/forms/data.py

@@ -217,6 +217,4 @@ REQUIRED_DISTRIBUTIONS = [
     ("other", "Other as necessary"),
 ]
 
-ENV_ROLES = [(role.value, role.value) for role in CSPRole] + [
-    ("No access", "No access")
-]
+ENV_ROLES = [(role.value, role.value) for role in CSPRole] + [("", "No access")]