pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Return correct error code

Browse Source
This commit is contained in:
George Drummond 2019-03-29 15:24:06 -04:00
parent a22b416c6a
commit 5cc8c05dbd
No known key found for this signature in database
GPG Key ID: 296DD6077123BF17
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
atst/routes/portfolios/index.py
View File

@ -16,6 +16,7 @@ from atst.models.permissions import Permissions
from atst.domain.permission_sets import PermissionSets from atst.domain.permission_sets import PermissionSets
from atst.domain.authz.decorator import user_can_access_decorator as user_can from atst.domain.authz.decorator import user_can_access_decorator as user_can
from atst.utils.flash import formatted_flash as flash from atst.utils.flash import formatted_flash as flash
from atst.domain.exceptions import UnauthorizedError
@portfolios_bp.route("/portfolios") @portfolios_bp.route("/portfolios")
@ -184,7 +185,7 @@ def portfolio_reports(portfolio_id):
def remove_member(portfolio_id, member_id): def remove_member(portfolio_id, member_id):
if member_id == str(g.current_user.id): if member_id == str(g.current_user.id):
raise UnauthorizedError( raise UnauthorizedError(
user=user, message="you cant remove yourself from the portfolio" user=g.current_user, action="you cant remove yourself from the portfolio"
) )
portfolio = Portfolios.get(g.current_user, portfolio_id) portfolio = Portfolios.get(g.current_user, portfolio_id)

2
tests/routes/portfolios/test_portfolios_index.py
View File

@ -126,7 +126,7 @@ def test_remove_portfolio_member_self(client, user_session):
follow_redirects=False, follow_redirects=False,
) )
assert response.status_code == 500 assert response.status_code == 404
assert ( assert (
PortfolioRoles.get(portfolio_id=portfolio.id, user_id=portfolio.owner.id).status PortfolioRoles.get(portfolio_id=portfolio.id, user_id=portfolio.owner.id).status
== PortfolioRoleStatus.ACTIVE == PortfolioRoleStatus.ACTIVE