diff --git a/atst/domain/csp/cloud/__init__.py b/atst/domain/csp/cloud/__init__.py index fc754c7d..99128d9c 100644 --- a/atst/domain/csp/cloud/__init__.py +++ b/atst/domain/csp/cloud/__init__.py @@ -1,5 +1,3 @@ -from .exceptions import * -from .models import * +from .azure_cloud_provider import AzureCloudProvider from .cloud_provider_interface import CloudProviderInterface from .mock_cloud_provider import MockCloudProvider -from .azure_cloud_provider import AzureCloudProvider diff --git a/atst/domain/csp/cloud/cloud_provider_interface.py b/atst/domain/csp/cloud/cloud_provider_interface.py index 087aada0..7f975c07 100644 --- a/atst/domain/csp/cloud/cloud_provider_interface.py +++ b/atst/domain/csp/cloud/cloud_provider_interface.py @@ -124,4 +124,3 @@ class CloudProviderInterface: exception if an error occurs while creating a subscription. """ raise NotImplementedError() - diff --git a/atst/domain/csp/cloud/mock_cloud_provider.py b/atst/domain/csp/cloud/mock_cloud_provider.py index 153c5a9d..a6c338b5 100644 --- a/atst/domain/csp/cloud/mock_cloud_provider.py +++ b/atst/domain/csp/cloud/mock_cloud_provider.py @@ -1,8 +1,35 @@ from uuid import uuid4 +from atst.domain.csp.cloud.exceptions import ( + BaselineProvisionException, + EnvironmentCreationException, + GeneralCSPException, + UserProvisioningException, + UserRemovalException, +) +from atst.domain.csp.cloud.models import BillingProfileTenantAccessCSPResult + from .cloud_provider_interface import CloudProviderInterface -from .exceptions import * -from .models import * +from .exceptions import ( + AuthenticationException, + AuthorizationException, + ConnectionException, + UnknownServerException, +) +from .models import ( + BillingInstructionCSPPayload, + BillingInstructionCSPResult, + BillingProfileCreationCSPPayload, + BillingProfileCreationCSPResult, + BillingProfileVerificationCSPPayload, + BillingProfileVerificationCSPResult, + TaskOrderBillingCreationCSPPayload, + TaskOrderBillingCreationCSPResult, + TaskOrderBillingVerificationCSPPayload, + TaskOrderBillingVerificationCSPResult, + TenantCSPPayload, + TenantCSPResult, +) class MockCloudProvider(CloudProviderInterface): diff --git a/atst/jobs.py b/atst/jobs.py index ab52cf17..7172343b 100644 --- a/atst/jobs.py +++ b/atst/jobs.py @@ -9,7 +9,8 @@ from atst.models import ( EnvironmentRole, PortfolioJobFailure, ) -from atst.domain.csp.cloud import CloudProviderInterface, GeneralCSPException +from atst.domain.csp.cloud.exceptions import GeneralCSPException +from atst.domain.csp.cloud import CloudProviderInterface from atst.domain.environments import Environments from atst.domain.portfolios import Portfolios from atst.domain.environment_roles import EnvironmentRoles diff --git a/atst/routes/applications/settings.py b/atst/routes/applications/settings.py index b4e75fc1..443989db 100644 --- a/atst/routes/applications/settings.py +++ b/atst/routes/applications/settings.py @@ -13,7 +13,7 @@ from atst.domain.environments import Environments from atst.domain.applications import Applications from atst.domain.application_roles import ApplicationRoles from atst.domain.audit_log import AuditLog -from atst.domain.csp.cloud import GeneralCSPException +from atst.domain.csp.cloud.exceptions import GeneralCSPException from atst.domain.common import Paginator from atst.domain.environment_roles import EnvironmentRoles from atst.domain.invitations import ApplicationInvitations diff --git a/tests/domain/cloud/test_azure_csp.py b/tests/domain/cloud/test_azure_csp.py index 9e87e7a7..0648ec1e 100644 --- a/tests/domain/cloud/test_azure_csp.py +++ b/tests/domain/cloud/test_azure_csp.py @@ -1,17 +1,19 @@ from unittest.mock import Mock - from uuid import uuid4 -from atst.domain.csp.cloud import ( - AzureCloudProvider, - BillingProfileCreationCSPResult, +from tests.factories import ApplicationFactory, EnvironmentFactory +from tests.mock_azure import AUTH_CREDENTIALS, mock_azure + +from atst.domain.csp.cloud import AzureCloudProvider +from atst.domain.csp.cloud.models import ( + BillingInstructionCSPPayload, + BillingInstructionCSPResult, BillingProfileCreationCSPPayload, + BillingProfileCreationCSPResult, BillingProfileTenantAccessCSPPayload, BillingProfileTenantAccessCSPResult, BillingProfileVerificationCSPPayload, BillingProfileVerificationCSPResult, - BillingInstructionCSPPayload, - BillingInstructionCSPResult, TaskOrderBillingCreationCSPPayload, TaskOrderBillingCreationCSPResult, TaskOrderBillingVerificationCSPPayload, @@ -20,10 +22,6 @@ from atst.domain.csp.cloud import ( TenantCSPResult, ) -from tests.mock_azure import mock_azure, AUTH_CREDENTIALS -from tests.factories import EnvironmentFactory, ApplicationFactory - - creds = { "home_tenant_id": "tenant_id", "client_id": "client_id", @@ -150,7 +148,7 @@ def test_create_tenant(mock_azure: AzureCloudProvider): **dict( creds=creds, user_id="admin", - password="JediJan13$coot", + password="JediJan13$coot", # pragma: allowlist secret domain_name="jediccpospawnedtenant2", first_name="Tedry", last_name="Tenet", diff --git a/tests/routes/applications/test_settings.py b/tests/routes/applications/test_settings.py index 37c71878..8f2595f2 100644 --- a/tests/routes/applications/test_settings.py +++ b/tests/routes/applications/test_settings.py @@ -12,7 +12,7 @@ from atst.domain.application_roles import ApplicationRoles from atst.domain.environment_roles import EnvironmentRoles from atst.domain.invitations import ApplicationInvitations from atst.domain.common import Paginator -from atst.domain.csp.cloud import GeneralCSPException +from atst.domain.csp.cloud.exceptions import GeneralCSPException from atst.domain.permission_sets import PermissionSets from atst.models.application_role import Status as ApplicationRoleStatus from atst.models.environment_role import CSPRole, EnvironmentRole