pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove TODO from admin.py

Browse Source
This commit is contained in:
graham-dds
2019-10-28 14:01:54 -04:00
parent eb22d5ec1e
commit 5526356938
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
atst/routes/portfolios/admin.py
View File

@@ -185,14 +185,13 @@ def remove_member(portfolio_id, portfolio_role_id):
raise UnauthorizedError( raise UnauthorizedError(
g.current_user, "you can't delete the portfolios PPoC from the portfolio" g.current_user, "you can't delete the portfolios PPoC from the portfolio"
) )
if ( if (
portfolio_role.latest_invitation portfolio_role.latest_invitation
and portfolio_role.status == PortfolioRoleStatus.PENDING and portfolio_role.status == PortfolioRoleStatus.PENDING
): ):
PortfolioInvitations.revoke(portfolio_role.latest_invitation.token) PortfolioInvitations.revoke(portfolio_role.latest_invitation.token)
else: else:
# TODO: should this cascade and disable any application and environment
# roles they might have?
PortfolioRoles.disable(portfolio_role=portfolio_role) PortfolioRoles.disable(portfolio_role=portfolio_role)
flash("portfolio_member_removed", member_name=portfolio_role.full_name) flash("portfolio_member_removed", member_name=portfolio_role.full_name)