pk/atst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add assertions to tests so they are more explicit

Browse Source
This commit is contained in:
leigh-mil 2019-01-09 10:10:42 -05:00
parent 8700ba37d3
commit 52bfb4b7d4
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/domain/test_audit_log.py
View File

@ -28,7 +28,8 @@ def test_non_admin_cannot_view_audit_log(developer):
def test_ccpo_can_view_audit_log(ccpo): def test_ccpo_can_view_audit_log(ccpo):
AuditLog.get_all_events(ccpo) events = AuditLog.get_all_events(ccpo)
assert len(events) > 0
def test_paginate_audit_log(ccpo): def test_paginate_audit_log(ccpo):
@ -42,7 +43,8 @@ def test_paginate_audit_log(ccpo):
def test_ccpo_can_view_ws_audit_log(ccpo): def test_ccpo_can_view_ws_audit_log(ccpo):
workspace = WorkspaceFactory.create() workspace = WorkspaceFactory.create()
AuditLog.get_workspace_events(ccpo, workspace) events = AuditLog.get_workspace_events(ccpo, workspace)
assert len(events) > 0
def test_ws_admin_can_view_ws_audit_log(): def test_ws_admin_can_view_ws_audit_log():
@ -54,12 +56,14 @@ def test_ws_admin_can_view_ws_audit_log():
role=Roles.get("admin"), role=Roles.get("admin"),
status=WorkspaceRoleStatus.ACTIVE, status=WorkspaceRoleStatus.ACTIVE,
) )
AuditLog.get_workspace_events(admin, workspace) events = AuditLog.get_workspace_events(admin, workspace)
assert len(events) > 0
def test_ws_owner_can_view_ws_audit_log(): def test_ws_owner_can_view_ws_audit_log():
workspace = WorkspaceFactory.create() workspace = WorkspaceFactory.create()
AuditLog.get_workspace_events(workspace.owner, workspace) events = AuditLog.get_workspace_events(workspace.owner, workspace)
assert len(events) > 0
def test_other_users_cannot_view_ws_audit_log(): def test_other_users_cannot_view_ws_audit_log():
@ -100,3 +104,7 @@ def test_ws_audit_log_only_includes_current_ws_events():
events = AuditLog.get_workspace_events(workspace.owner, workspace) events = AuditLog.get_workspace_events(workspace.owner, workspace)
for event in events: for event in events:
assert event.workspace_id == workspace.id or event.resource_id == workspace.id assert event.workspace_id == workspace.id or event.resource_id == workspace.id
assert (
not event.workspace_id == other_workspace.id
or event.resource_id == other_workspace.id
)